Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/collections/componentSet.ts
Original file line number Diff line number Diff line change
Expand Up @@ -816,6 +816,10 @@ const constructFullName = (registry: RegistryAccess, type: MetadataType, fullNam
// a "/" so the metadata API can identify it as a folder.
['DashboardFolder', 'ReportFolder', 'EmailTemplateFolder'].includes(type.name) && !fullName.endsWith('/')
? `${fullName}/`
: // TagSet nests recursively by parent-set identity. inFolder stores it on disk as A/B/C, but the
// metadata API contract for TagSet fullNames is dot-separated (A.B.C), so translate on the way out.
type.name === 'TagSet'
? fullName.replace(/\//g, '.')
: registry.getParentType(type.name)?.strategies?.recomposition === 'startEmpty' && fullName.includes('.')
? // they're reassembled like CustomLabels.MyLabel
fullName.split('.')[1]
Expand Down
12 changes: 11 additions & 1 deletion src/registry/metadataRegistry.json
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,8 @@
"cnfgItemTypeRelationDef": "cnfgitemtyperelationdef",
"cnfgMgmtRelationTypeDef": "cnfgmgmtrelationtypedef",
"meetingPlaybookDefinition": "meetingplaybookdefinition",
"idpConfiguration": "idpconfiguration"
"idpConfiguration": "idpconfiguration",
"tagSet": "tagset"
},
"types": {
"accesscontrolpolicy": {
Expand Down Expand Up @@ -5394,6 +5395,15 @@
"adapter": "bundle"
},
"supportsPartialDelete": true
},
"tagset": {
"id": "tagset",
"name": "TagSet",
"suffix": "tagSet",
"directoryName": "tagSet",
"inFolder": true,
"strictDirectoryName": false,
"supportsWildcardAndName": true
}
}
}
14 changes: 14 additions & 0 deletions test/collections/componentSet.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -944,6 +944,20 @@ describe('ComponentSet', () => {
]);
});

it('should translate a recursively-foldered TagSet path to a dot-separated member', async () => {
// On disk, nested tag sets are stored as folders (tagSet/A/B/C.tagSet), so the resolved
// fullName is slash-separated. The TagSet metadata API contract is dot-separated.
const member = { fullName: 'DataGovernanceTags/CustomTags__as/CustomTagsChild1__as', type: 'TagSet' };
const set = new ComponentSet([member], registryAccess);

expect((await set.getObject()).Package.types).to.deep.equal([
{
name: 'TagSet',
members: ['DataGovernanceTags.CustomTags__as.CustomTagsChild1__as'],
},
]);
});

it('should include required child types as defined in the registry', async () => {
const set = new ComponentSet([MATCHING_RULES_COMPONENT]);
expect((await set.getObject()).Package.types).to.deep.equal([
Expand Down