fix(plugins/ray): remove terminal-only noise from Ray logs - #7890
Merged
pingsutw merged 1 commit intoAug 21, 2026
Merged
Conversation
|
This PR was flagged by our automated quality checks. If you're a genuine We appreciate your contribution and apologize if this is a false positive! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7890 +/- ##
=======================================
Coverage 57.24% 57.24%
=======================================
Files 931 931
Lines 58269 58279 +10
=======================================
+ Hits 33354 33364 +10
Misses 21856 21856
Partials 3059 3059
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Ray colorizes its log prefixes with ANSI escapes and renders Ray Data progress bars as repeated redraws. Both target an interactive terminal; a Ray task's output is collected from a pod, so the escapes render as literal noise and the progress bar repaints bloat the log. Set RAY_COLOR_PREFIX=0 and RAY_DATA_DISABLE_PROGRESS_BARS=1 on the head and worker containers so the collected logs stay readable. Backport of flyteorg#7504, which landed on the v2 branch only. Both branches ship the same Ray plugin. Signed-off-by: 1fanwang <1fannnw@gmail.com>
1fanwang
force-pushed
the
1fanwang-ray-log-noise-env-vars-v1
branch
from
August 20, 2026 20:17
c750569 to
d9753c1
Compare
1fanwang
changed the title
|
This PR was flagged by our automated quality checks. If you're a genuine We appreciate your contribution and apologize if this is a false positive! |
Contributor
Author
|
This backports #7504 to the v1 Ray plugin. The current body includes the red/green |
1fanwang
changed the title
pingsutw
approved these changes
Aug 21, 2026
Comment on lines
+379
to
+386
| { | ||
| Name: "RAY_COLOR_PREFIX", | ||
| Value: "0", | ||
| }, | ||
| { | ||
| Name: "RAY_DATA_DISABLE_PROGRESS_BARS", | ||
| Value: "1", | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Related to #7504
Why are the changes needed?
Ray formats logs for an interactive terminal. In collected pod logs, ANSI escapes
appear as literal characters and progress-bar redraws become repeated lines.
Before this change, v1 Ray task output is buried in that noise. After this change,
head and worker logs are plain text without progress-bar redraws, matching v2.
What changes were proposed in this pull request?
Set Ray's existing environment switches on both containers:
RAY_COLOR_PREFIX=0andRAY_DATA_DISABLE_PROGRESS_BARS=1.How was this patch tested?
The resource builder creates the RayJob and checks both variables on the head and
worker containers. A live pod-log comparison has not been run.
Labels
fixed
Setup process
No live cluster. The test drives the plugin's resource builder.
Check all the applicable boxes
Related PRs