Skip to content

Add hosted check hint to CI failures - #3

Merged
flvmnt merged 1 commit into
mainfrom
codex/cloud-required-check-hint
Sep 16, 2026
Merged

flvmnt merged 1 commit into
mainfrom
codex/cloud-required-check-hint

Conversation

@flvmnt

@flvmnt flvmnt commented Sep 16, 2026

Copy link
Copy Markdown
Owner

Summary

  • print one pgfence Cloud line only when CI blocks
  • support suppression with --no-cloud-hint or PGFENCE_CLOUD_HINT=0
  • add the required-check path to README.md and RULES.md
  • update the brace-expansion security override

Verification

  • docs coverage passed
  • typecheck and build passed
  • public boundary check passed
  • lint passed
  • 730 tests passed
  • pnpm audit --prod reports no known vulnerabilities

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-16T22:30:51.576215Z b65e023 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@flvmnt
flvmnt merged commit 97d937f into main Sep 16, 2026
2 checks passed
@flvmnt
flvmnt deleted the codex/cloud-required-check-hint branch September 16, 2026 22:29
flvmnt added a commit that referenced this pull request Sep 16, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b65e023544

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/index.ts
.option('--min-pg-version <version>', 'Minimum PostgreSQL version to assume', '14')
.option('--max-risk <risk>', 'Maximum allowed risk level for CI mode', 'high')
.option('--ci', 'CI mode: exit 1 if max risk exceeded', false)
.option('--no-cloud-hint', 'Do not print the pgfence Cloud hint when CI blocks')

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Apply the Cloud hint to trace CI failures

The documented pgfence trace --ci path also blocks with exit 1 for risk, trace errors, or mismatches (src/index.ts lines 763–770), but the new option and hint are registered only for analyze. Consequently, trace CI failures never show the advertised hint, and passing --no-cloud-hint to trace is rejected as an unknown option. Register the suppression option and emit the hint at the trace CI gate as well.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant