Repository navigation
docs(contributing): issues cite behaviour, and two labels carry order - #466
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 54 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merging this PR will improve performance by 11%
Performance Changes
Tip Curious why this is faster? Comment Comparing Footnotes
|
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
One section in
CONTRIBUTING.md, 14 lines. No code, no gate, no tool.Kept to rules on purpose. The file's own charter is "readable in one sitting
and go stale only when a command changes", so the evidence below stays here in
the PR rather than in the page — which is the same split
docs/already runs on.The failure the rule is for
Triaging the backlog surfaced the same defect four times, and it is mechanical
rather than a matter of care:
_sum_piece/_group_piece/_shift_pieceatexecutor.py:486-539_group_fragmentSQL fragmentraise RelationalBuildErrorinlowering.py"bench/results/latest.jsonlon thepolars-enginebranchIn every case the finding survived the rewrite and the evidence for it
did not, so the issue had to be closed and re-filed rather than read.
#474 then found the same rot pointing the other way — code and tests linking to
ROADMAP sections (Track 5, ROADMAP 2c, ROADMAP 5c, "The degree axis")
that never existed or no longer did, two of them inside user-facing error
messages. Same rule, both directions.
The order half
now, capped at five — currently A scalar variable cannot be masked: presence frames have no column to hold the empty coordinate #340, The where grammar takes no quoted string and no datetime, and checks no dtype #460, The breaking-surface window: sequence #67, #332 and #29 as one decision #432, at(): a consumer report — two downstream features blocked, and what the surface needs to cover #185, optional: on parameter declarations — an absent table means no rows #217. The cap isthe mechanism: a claimed priority order over forty-six issues is fiction, and
five is the smallest thing that is not.
Track 3 — capabilities, and the degree line #472 with 21 sub-issues between them.
blocked:decision, the siblingblocked:upstreamnever had — Namespacing: qualified names for component libraries #29, Shape operators: pushforward/pullback taxonomy, and three renames (polars rewrite of #50) #332and version: key in model files — and the policy that gives it meaning #67 all wait on The breaking-surface window: sequence #67, #332 and #29 as one decision #432 and nothing said so outside their bodies.
Considered and rejected
A GitHub Project. The account already carries six, one untitled; a seventh
needing manual grooming would drift the same way. The deciding argument is
cadence, not capability: a Project's value is continuous status curation, and
neither a solo maintainer nor an agent invoked on demand supplies that.
track:1–track:4labels. Tried, and reverted within the hour — they were ahand-mirror of a markdown table, covered only 20 of 47 open issues, were not a
partition (three issues sat in two tracks), and three of them were simply wrong
because the extraction ran past a section boundary. Sub-issue parentage does the
same job structurally and cannot drift.
A tool that greps issue bodies for dead symbols. It would have caught all
four rows above, and it is still not worth it: bodies legitimately name deleted
things (#332's argument is that #50 cited
_sum_piece), upstream paths, andproposed names that do not exist yet — so it needs a suppression list, a second
thing to groom. Its payoff also lands at triage, which is when the bodies are
being read anyway.
Verified
ruff checkclean, 764 passed,mkdocs build --strictclean. Merges cleanlywith #474 (trial-merged locally); the two touch different sections of the file.