Repository navigation
feat(typesetting): the math names a property after itself, and the reading page gives the tables of sets and properties - #4
Draft
FBumann wants to merge 2 commits into
Conversation
…ading page gives the tables of sets and properties A property read prints as `bus(g)`, and the legend maps it from its subject: `bus: G → B`, or `zone: generator_period → Z` for a property of a set. `docs/reference/reading.md` gives the canonical tables and the wide form an engine may accept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6yvGzZN2iR4WyA9RumvvJ
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6yvGzZN2iR4WyA9RumvvJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
The following content was generated by AI.
What this changes
A property read prints as
bus(g)in all three formats, rather than as the name of its table,generator.bus(g). The legend maps each property from its subject.docs/reference/reading.mdgives the canonical tables, the inner join, and the wide form an engine may accept. Stacked on #3.Why
This is PR 4 of the stack in which sets and properties replace relations.
What prints
sum(x, over=generator, by=generator[bus, carrier])\sum_{g \in \mathcal{G} \,:\, \mathrm{bus}(g) = b \wedge \mathrm{carrier}(g) = c} x_{g,t}where: line[bus1]\mathrm{bus1}(l) \text{ is defined}at(price, by=generator_period[zone])\mathrm{price}_{\mathrm{zone}(g,\ r),r}\mathrm{bus}: \mathcal{G} \to \mathcal{B}\mathrm{zone}: \mathrm{generator\_period} \to \mathcal{Z}missing: absent`line[bus1]` is `absent` where the data has no rowmodel.yamlto reach every line the typesetter can print, so they have to be there. The golden files anddocs/reference/notation.mdare regenerated; the diff is the review.reading.mdhas a new section, "The tables of sets and properties". Its Python block runs intests/test_reading_page.py, which now checks 30 claims (it checked 24).Departures, and what this PR does not do
bus(g)andbus(l). The argument tells them apart, and the legend lists both under the dimension they map into.relations:, so their generated pages do not change here. That is PR 5.Gates, and the mutation table
pixi run lint,pixi run test(3227 passed, 1 skipped),pixi run docs-build(strict) andpixi run render-tex(54 specs).compile-tex. Tectonic cannot download its bundle in this container.subject[property]Generated by Claude Code