Repository navigation
Introduce namespace management in ArtifactGenerator - #392
Open
matheuscscp wants to merge 1 commit into
Open
matheuscscp wants to merge 1 commit into
matheuscscp wants to merge 1 commit into
Conversation
matheuscscp
force-pushed
the
namespaces
branch
from
October 4, 2026 21:31
b8e3a41 to
bffeea7
Compare
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
matheuscscp
force-pushed
the
namespaces
branch
from
October 5, 2026 12:57
bffeea7 to
abbbefa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #388
This PR introduces two things that are tightly coupled: the ability to generate namespaces from
.spec.artifacts[].namespace, and also making this field aware of.spec.pathPattern. Together, these two behaviors allow Flux users to generate namespaces from directories in source artifacts.We are also aligning garbage collection behavior with kustomize-controller, which puts back objects into the inventory and keeps the finalizer when the AG is on deletion in case the API server does not confirm the deletion request for the object. Backoff retries from controller-runtime reattempt the finalization.
The API:
The namespaces generated by an ArtifactGenerator are the union of the namespaces rendered by all
.spec.artifacts[]. The field.spec.commonMetadatais used for the metadata of the namespaces. If needed later, we can add.spec.namespaces.metadatato give users an override that is special for namespaces. Drift is detected against the inventory for garbage collection and against the metadata fields for correcting the remaining namespaces. Conflicts with other ArtifactGenerators and observability are similar to how we did it for ExternalArtifact.