Migrate event recording to fluxcd/pkg/runtime/events v1 - #1602
Open
renatovassao wants to merge 1 commit into
Open
renatovassao wants to merge 1 commit into
renatovassao wants to merge 1 commit into
Conversation
Replace k8s.io/client-go/tools/record with the Flux events recorder which emits events.k8s.io/v1 Events with structured fields (Action, Related). Add Source to reconcile.Request so events reference the originating source object. Remove the internal FakeRecorder, using events.FakeRecorder from fluxcd/pkg instead Signed-off-by: Adrian Fernandez De La Torre <adri1197@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the controller's event recording from the legacy
k8s.io/client-go/tools/recordinterface togithub.com/fluxcd/pkg/runtime/events, which emits structuredevents.k8s.io/v1Events.kuberecorder.EventRecorderwithevents.EventRecorderthroughout the reconciler and action reconcilersSourcefield toreconcile.Requestso events include aRelatedobject reference pointing to the source (HelmChart, OCIRepository, etc.).Action(install, upgrade, rollback, etc.) andRelatedinstead of encoding everything in the message string.github.com/fluxcd/pkg/apis/event/v1beta1togithub.com/fluxcd/pkg/apis/event/v1internal/testutil/FakeRecorderin favor ofevents.NewFakeRecorderfromfluxcd/pkg/runtime/eventseventsv1.Eventfields (Note,Action,Regarding,Related) instead ofcorev1.Event.MessageCloses fluxcd/flux2#5761
Original PR: #1510