update iOS/macOS deployment targets to 15.0 and fix isiOSAppOnVision detection #3812#3815
Closed
Melsaeed276 wants to merge 13 commits into
Closed
update iOS/macOS deployment targets to 15.0 and fix isiOSAppOnVision detection #3812#3815Melsaeed276 wants to merge 13 commits into
Melsaeed276 wants to merge 13 commits into
Conversation
…lus.podspec Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…s/Sources/device_info_plus/FPPDeviceInfoPlusPlugin.m Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates device_info_plus Apple platform deployment targets and adjusts the iOS “App on Vision” detection to avoid compile-time API availability issues by switching to runtime selector checks.
Changes:
- Bumped CocoaPods deployment targets (iOS to 15.0, macOS to 15.0) and aligned example Xcode projects accordingly.
- Updated
isiOSAppOnVisiondetection to userespondsToSelector:with runtime invocation instead of directly calling the property. - Added/stopped-ignoring example Podfiles to force platform versions.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/device_info_plus/device_info_plus/macos/device_info_plus.podspec | Raises macOS pod deployment target to 15.0. |
| packages/device_info_plus/device_info_plus/ios/device_info_plus/Sources/device_info_plus/FPPDeviceInfoPlusPlugin.m | Switches isiOSAppOnVision detection to runtime selector-based invocation. |
| packages/device_info_plus/device_info_plus/ios/device_info_plus.podspec | Raises iOS pod deployment target to 15.0. |
| packages/device_info_plus/device_info_plus/example/macos/Runner.xcodeproj/project.pbxproj | Raises example macOS deployment target to 15.0 in build configs. |
| packages/device_info_plus/device_info_plus/example/macos/Podfile | Adds a (currently minimal) macOS Podfile declaring platform 15.0. |
| packages/device_info_plus/device_info_plus/example/ios/Runner.xcodeproj/project.pbxproj | Raises example iOS deployment target to 15.0 in build configs. |
| packages/device_info_plus/device_info_plus/example/ios/Podfile | Adds a (currently minimal) iOS Podfile declaring platform 15.0. |
| packages/device_info_plus/device_info_plus/.gitignore | Un-ignores the example Podfiles so they are tracked. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…r.xcodeproj/project.pbxproj Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…r.xcodeproj/project.pbxproj Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…lus.podspec Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…r.xcodeproj/project.pbxproj Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
|
@Melsaeed276 I already closed another PR of you #3812 - don't spam the repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the minimum deployment targets and improves the
isiOSAppOnVisiondetection:12.0to15.0@available(iOS 26.1, *)to runtime detection using@available(iOS 15.0, *)+@available(iOS 26.1, *)+respondsToSelector:. This ensures theisiOSAppOnVisionproperty is correctly detected at runtime without causing compile-time warnings on older SDKs.Related Issues
Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).