Skip to content

refactor(ci): extract process runner and harden workflow git error handling - #18

Merged
jtmcdole merged 2 commits into
mainfrom
ci_cleanups
Sep 17, 2026
Merged

jtmcdole merged 2 commits into
mainfrom
ci_cleanups

Conversation

@jtmcdole

Copy link
Copy Markdown
Member
  • Extract ProcessRunner and ProcessLogger utilities for subprocess execution.
  • Support throwOnError in defaultGitList so validators fail visibly on git error.
  • Propagate git discovery failures in RfcValidator as actionable errors.
  • Set fetch-depth: 0 in workflows to ensure base branch refs are available.
  • Remove error silencing in rfc-lint workflow to fail fast on invalid refs.

Stack created with GitHub Stacks CLIGive Feedback 💬

@jtmcdole
jtmcdole added this pull request to stack #19 September 13, 2026 16:52
@jtmcdole
jtmcdole requested a review from zanderso September 15, 2026 20:13
@jtmcdole
jtmcdole marked this pull request as ready for review September 15, 2026 20:13

@zanderso zanderso left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would https://pub.dev/packages/process_runner help with what you need to do here?

Comment thread lib/src/validator.dart Outdated
Comment thread lib/logprocess.dart Outdated
@jtmcdole

Copy link
Copy Markdown
Member Author

Would https://pub.dev/packages/process_runner help with what you need to do here?

If we needed to handle pooling or more complex process management, yes, but for now I don't think it crosses that threshold.

@jtmcdole
jtmcdole requested a review from zanderso September 16, 2026 17:29
…ndling

- Extract ProcessRunner and ProcessLogger utilities for subprocess execution.
- Support throwOnError in defaultGitList so validators fail visibly on git error.
- Propagate git discovery failures in RfcValidator as actionable errors.
- Set fetch-depth: 0 in workflows to ensure base branch refs are available.
- Remove error silencing in rfc-lint workflow to fail fast on invalid refs.

@eyebrowsoffire eyebrowsoffire left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtmcdole
jtmcdole added this pull request to the merge queue Sep 17, 2026
Merged via the queue into main with commit c2a01e0 Sep 17, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants