Skip to content

[ai] bootstrap ABOUT.md recursive summaries and support for context priming - #9115

Merged
pq merged 3 commits into
flutter:mainfrom
pq:egm_bootstrap
Sep 21, 2026
Merged

pq merged 3 commits into
flutter:mainfrom
pq:egm_bootstrap

Conversation

@pq

@pq pq commented Sep 7, 2026 •

Copy link
Copy Markdown
Collaborator

See flutter/dart-intellij-third-party#637 for context.


Review the contribution guidelines below:

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
  • I've included the required information in the description above.
  • My up-to-date information is in the AUTHORS file.
  • I've updated CHANGELOG.md if appropriate.
Contribution guidelines:
  • See
    our contributor guide and
    the Flutter organization contributor guide
    for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Dart contributions to our repos should follow the Dart style guide and use
    dart format.
  • Java and Kotlin contributions should strive to follow Java and Kotlin best
    practices (discussion).

@pq
pq requested a review from helin24 as a code owner September 7, 2026 23:40
@pq
pq marked this pull request as draft September 7, 2026 23:40

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new agent skill, load-repo-context, and adds hierarchical ABOUT.md architecture manifests across various directories to map out subsystems, invariants, and side effects. The review feedback focuses on improving the usability of these manifests by suggesting that child manifest paths be formatted as clickable Markdown links to ensure consistency and facilitate easier navigation.

Comment thread src/ABOUT.md
Comment on lines +8 to +10
- `./icons/ABOUT.md`
- `./io/ABOUT.md`
- `./org/ABOUT.md`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

[CONCERN] Format the child manifest paths as clickable Markdown links to maintain consistency with other ABOUT.md files in the repository (such as the root ABOUT.md and tool/ABOUT.md) and to facilitate easier navigation for both developers and AI agents.

Suggested change
- `./icons/ABOUT.md`
- `./io/ABOUT.md`
- `./org/ABOUT.md`
- [./icons/ABOUT.md](./icons/ABOUT.md)
- [./io/ABOUT.md](./io/ABOUT.md)
- [./org/ABOUT.md](./org/ABOUT.md)
References
  1. Prefix every comment with a severity category such as [CONCERN] for maintainability issues. (link)

Comment thread src/io/ABOUT.md
Structural package containing core input/output and Flutter integrations.

## Interface
- `./flutter/ABOUT.md`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

[CONCERN] Format the child manifest path as a clickable Markdown link to maintain consistency with other ABOUT.md files in the repository.

Suggested change
- `./flutter/ABOUT.md`
- [./flutter/ABOUT.md](./flutter/ABOUT.md)
References
  1. Prefix every comment with a severity category such as [CONCERN] for maintainability issues. (link)

Comment thread src/io/flutter/ABOUT.md
Comment on lines +18 to +46
- `./actions/ABOUT.md`
- `./analytics/ABOUT.md`
- `./android/ABOUT.md`
- `./console/ABOUT.md`
- `./dart/ABOUT.md`
- `./deeplinks/ABOUT.md`
- `./devtools/ABOUT.md`
- `./editor/ABOUT.md`
- `./font/ABOUT.md`
- `./inspections/ABOUT.md`
- `./jxbrowser/ABOUT.md`
- `./logging/ABOUT.md`
- `./module/ABOUT.md`
- `./project/ABOUT.md`
- `./propertyeditor/ABOUT.md`
- `./pub/ABOUT.md`
- `./refactoring/ABOUT.md`
- `./run/ABOUT.md`
- `./samples/ABOUT.md`
- `./sdk/ABOUT.md`
- `./settings/ABOUT.md`
- `./survey/ABOUT.md`
- `./template/ABOUT.md`
- `./test/ABOUT.md`
- `./toolwindow/ABOUT.md`
- `./utils/ABOUT.md`
- `./view/ABOUT.md`
- `./vmService/ABOUT.md`
- `./widgetpreview/ABOUT.md`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

[CONCERN] Format the child manifest paths as clickable Markdown links to maintain consistency with other ABOUT.md files in the repository.

- [./actions/ABOUT.md](./actions/ABOUT.md)
- [./analytics/ABOUT.md](./analytics/ABOUT.md)
- [./android/ABOUT.md](./android/ABOUT.md)
- [./console/ABOUT.md](./console/ABOUT.md)
- [./dart/ABOUT.md](./dart/ABOUT.md)
- [./deeplinks/ABOUT.md](./deeplinks/ABOUT.md)
- [./devtools/ABOUT.md](./devtools/ABOUT.md)
- [./editor/ABOUT.md](./editor/ABOUT.md)
- [./font/ABOUT.md](./font/ABOUT.md)
- [./inspections/ABOUT.md](./inspections/ABOUT.md)
- [./jxbrowser/ABOUT.md](./jxbrowser/ABOUT.md)
- [./logging/ABOUT.md](./logging/ABOUT.md)
- [./module/ABOUT.md](./module/ABOUT.md)
- [./project/ABOUT.md](./project/ABOUT.md)
- [./propertyeditor/ABOUT.md](./propertyeditor/ABOUT.md)
- [./pub/ABOUT.md](./pub/ABOUT.md)
- [./refactoring/ABOUT.md](./refactoring/ABOUT.md)
- [./run/ABOUT.md](./run/ABOUT.md)
- [./samples/ABOUT.md](./samples/ABOUT.md)
- [./sdk/ABOUT.md](./sdk/ABOUT.md)
- [./settings/ABOUT.md](./settings/ABOUT.md)
- [./survey/ABOUT.md](./survey/ABOUT.md)
- [./template/ABOUT.md](./template/ABOUT.md)
- [./test/ABOUT.md](./test/ABOUT.md)
- [./toolwindow/ABOUT.md](./toolwindow/ABOUT.md)
- [./utils/ABOUT.md](./utils/ABOUT.md)
- [./view/ABOUT.md](./view/ABOUT.md)
- [./vmService/ABOUT.md](./vmService/ABOUT.md)
- [./widgetpreview/ABOUT.md](./widgetpreview/ABOUT.md)
References
  1. Prefix every comment with a severity category such as [CONCERN] for maintainability issues. (link)

Comment on lines +29 to +32
- `./common/ABOUT.md`
- `./coverage/ABOUT.md`
- `./daemon/ABOUT.md`
- `./test/ABOUT.md`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

[CONCERN] Format the child manifest paths as clickable Markdown links to maintain consistency with other ABOUT.md files in the repository.

Suggested change
- `./common/ABOUT.md`
- `./coverage/ABOUT.md`
- `./daemon/ABOUT.md`
- `./test/ABOUT.md`
- [./common/ABOUT.md](./common/ABOUT.md)
- [./coverage/ABOUT.md](./coverage/ABOUT.md)
- [./daemon/ABOUT.md](./daemon/ABOUT.md)
- [./test/ABOUT.md](./test/ABOUT.md)
References
  1. Prefix every comment with a severity category such as [CONCERN] for maintainability issues. (link)

- `VMServiceManager`
- `VmServiceConsumers`
- `VmServiceWrapper`
- `./frame/ABOUT.md` - Subpackage for stack frame evaluation and variable inspection

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

[CONCERN] Format the child manifest path as a clickable Markdown link to maintain consistency with other ABOUT.md files in the repository.

Suggested change
- `./frame/ABOUT.md` - Subpackage for stack frame evaluation and variable inspection
- [./frame/ABOUT.md](./frame/ABOUT.md) - Subpackage for stack frame evaluation and variable inspection
References
  1. Prefix every comment with a severity category such as [CONCERN] for maintainability issues. (link)

Comment thread src/org/dartlang/ABOUT.md
Structural package for Dart language integration and analysis.

## Interface
- `./analysis/ABOUT.md`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

[CONCERN] Format the child manifest path as a clickable Markdown link to maintain consistency with other ABOUT.md files in the repository.

Suggested change
- `./analysis/ABOUT.md`
- [./analysis/ABOUT.md](./analysis/ABOUT.md)
References
  1. Prefix every comment with a severity category such as [CONCERN] for maintainability issues. (link)

Structural package for Dart code analysis tools.

## Interface
- `./server/ABOUT.md`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

[CONCERN] Format the child manifest path as a clickable Markdown link to maintain consistency with other ABOUT.md files in the repository.

Suggested change
- `./server/ABOUT.md`
- [./server/ABOUT.md](./server/ABOUT.md)
References
  1. Prefix every comment with a severity category such as [CONCERN] for maintainability issues. (link)

Structural package for the Dart Analysis Server integration.

## Interface
- `./protocol/ABOUT.md`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

[CONCERN] Format the child manifest path as a clickable Markdown link to maintain consistency with other ABOUT.md files in the repository.

Suggested change
- `./protocol/ABOUT.md`
- [./protocol/ABOUT.md](./protocol/ABOUT.md)
References
  1. Prefix every comment with a severity category such as [CONCERN] for maintainability issues. (link)

Structural package containing JetBrains-specific IDE integrations.

## Interface
- `./android/ABOUT.md`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

[CONCERN] Format the child manifest path as a clickable Markdown link to maintain consistency with other ABOUT.md files in the repository.

Suggested change
- `./android/ABOUT.md`
- [./android/ABOUT.md](./android/ABOUT.md)
References
  1. Prefix every comment with a severity category such as [CONCERN] for maintainability issues. (link)

Structural package containing JetBrains Android integrations.

## Interface
- `./facet/ABOUT.md`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

[CONCERN] Format the child manifest path as a clickable Markdown link to maintain consistency with other ABOUT.md files in the repository.

Suggested change
- `./facet/ABOUT.md`
- [./facet/ABOUT.md](./facet/ABOUT.md)
References
  1. Prefix every comment with a severity category such as [CONCERN] for maintainability issues. (link)

@pq
pq marked this pull request as ready for review September 21, 2026 13:59
@pq

pq commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator Author

Ready for review!

@pq

pq commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator Author

Build greenness gated by: #9132

@pq

pq commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator Author

RE: gemini review feedback: this format worked well in my evals so I'm hesitant to make any changes. That said, I'll loop back and test the proposed refinements in my next round of evalutaions.

@helin24

helin24 commented Sep 21, 2026

Copy link
Copy Markdown
Member

I don't have an opinion on whether these should be clickable. (or on the Dart repo comment of whether to split up the interface notes)

@pq
pq merged commit 79f66e0 into flutter:main Sep 21, 2026
14 checks passed
@pq
pq deleted the egm_bootstrap branch September 21, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants