Repository navigation
web_compiler_test: Enable SwiftShader on headless VMs - #10056
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Chrome capabilities in web_compiler_test.dart to support WebGL for the skwasm renderer on headless Linux and Windows VMs by enabling SwiftShader. It also attempts to conditionally set the Chrome binary path. However, a critical issue was identified where the syntax used for the conditional binary path is invalid in Dart and will cause a compilation error. A suggestion was provided to use a collection if statement instead.
Contributor
Author
|
Submitting past DCM findings, which are unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10032
'binary': ?Platform.environment['CHROME_EXECUTABLE']toCapabilities.chromeOptionswhenCHROME_EXECUTABLEis set in the environment.--use-gl=angle,--use-angle=swiftshader,--enable-unsafe-swiftshader,--disable-gpu-sandbox) on Linux and Windows so headless Chrome on GPU-less CI VMs provides WebGL support required byFlutterLoader to select the skwasm renderer.