Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app_dart/lib/src/foundation/github_checks_util.dart
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ class GithubChecksUtil {
String name, {
github.CheckRunOutput? output,
github.CheckRunConclusion? conclusion,
github.CheckRunStatus status = github.CheckRunStatus.queued,
String? detailsUrl,
}) async {
const r = RetryOptions(maxAttempts: 3, delayFactor: Duration(seconds: 2));
Expand All @@ -141,6 +142,7 @@ class GithubChecksUtil {
name,
output: output,
conclusion: conclusion,
status: status,
detailsUrl: detailsUrl,
);
},
Expand All @@ -161,6 +163,7 @@ class GithubChecksUtil {
String name, {
github.CheckRunOutput? output,
github.CheckRunConclusion? conclusion,
github.CheckRunStatus status = github.CheckRunStatus.queued,
String? detailsUrl,
}) async {
final gitHubClient = await config.createGitHubClient(slug: slug);
Expand All @@ -170,6 +173,7 @@ class GithubChecksUtil {
headSha: sha,
output: output,
conclusion: conclusion,
status: status,
detailsUrl: detailsUrl,
);
}
Expand Down
1 change: 1 addition & 0 deletions app_dart/lib/src/service/luci_build_service.dart
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,7 @@ class LuciBuildService {
title: Config.kPresubmitCheckName,
summary: Scheduler.kPresubmitCheckDescription,
),
status: CheckRunStatus.inProgress,
detailsUrl: checkRun.detailsUrl,
);
}
Expand Down
3 changes: 2 additions & 1 deletion app_dart/lib/src/service/scheduler.dart
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ class Scheduler {
/// This description appears next to the Github check run in the pull request
/// and merge queue UI.
static const String kPresubmitCheckDescription =
'The presubmit check is a GitHub check that prevents a PR from being '
'The Presubmit check is a GitHub check that prevents a PR from being '
'merged or enqueued before it is ready. It becomes green automatically '
'when all tests pass. It will fail if at least one job is failed and '
'reset to in-progress when all the failed jobs are retried. If it fails, '
Expand Down Expand Up @@ -922,6 +922,7 @@ $s
title: Config.kPresubmitCheckName,
summary: kPresubmitCheckDescription,
),
status: CheckRunStatus.inProgress,
detailsUrl: detailsUrl,
);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -691,6 +691,7 @@ void main() {
any,
output: anyNamed('output'),
conclusion: anyNamed('conclusion'),
status: anyNamed('status'),
detailsUrl: anyNamed('detailsUrl'),
),
).thenAnswer(
Expand Down Expand Up @@ -720,6 +721,7 @@ void main() {
title: Config.kPresubmitCheckName,
summary: Scheduler.kPresubmitCheckDescription,
),
status: CheckRunStatus.inProgress,
detailsUrl: checkRunGuard.detailsUrl,
),
).called(1);
Expand Down Expand Up @@ -797,6 +799,7 @@ void main() {
Config.kPresubmitCheckName,
output: anyNamed('output'),
conclusion: anyNamed('conclusion'),
status: anyNamed('status'),
detailsUrl: anyNamed('detailsUrl'),
),
);
Expand Down
2 changes: 2 additions & 0 deletions app_dart/test/service/scheduler_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2040,6 +2040,7 @@ targets:
any,
output: anyNamed('output'),
conclusion: anyNamed('conclusion'),
status: anyNamed('status'),
detailsUrl: anyNamed('detailsUrl'),
),
).thenAnswer((Invocation invocation) async {
Expand All @@ -2066,6 +2067,7 @@ targets:
Config.kPresubmitCheckName,
output: anyNamed('output'),
conclusion: anyNamed('conclusion'),
status: CheckRunStatus.inProgress,
detailsUrl: anyNamed('detailsUrl'),
),
);
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading