feat: adds Docker health check - #1937
Merged
pedrolamas merged 2 commits intoAug 18, 2026
Merged
Conversation
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a lightweight Docker health check for Fluidd’s NGINX-based images by introducing a /healthz endpoint and wiring a Dockerfile HEALTHCHECK to poll it, with accompanying docs and CI tweaks.
Changes:
- Add
location = /healthzin the NGINX config template returning200with plain-textok. - Add a Docker image
HEALTHCHECKthat pollshttp://127.0.0.1:${PORT}/healthz, and plumbPORTvia build args/env. - Update build workflow to pass
PORTas a Docker build-arg (removing the priorsed-based template rewrite) and document the new health check.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| server/nginx/default.conf.template | Adds /healthz endpoint for local health probing. |
| Dockerfile | Introduces PORT env and Docker HEALTHCHECK polling /healthz. |
| .github/workflows/build.yml | Removes template rewrite step; passes PORT build-arg for image variants. |
| docs/docs/getting-started.md | Documents the health check and Compose service_healthy usage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a basic health check to the docker images.