Skip to content

feat: adds Docker health check - #1937

Merged
pedrolamas merged 2 commits into
fluidd-core:developfrom
pedrolamas:pedrolamas/docker-healthcheck
Aug 18, 2026
Merged

feat: adds Docker health check#1937
pedrolamas merged 2 commits into
fluidd-core:developfrom
pedrolamas:pedrolamas/docker-healthcheck

Conversation

@pedrolamas

Copy link
Copy Markdown
Member

Adds a basic health check to the docker images.

Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
@pedrolamas pedrolamas added this to the 1.37.5 milestone Aug 18, 2026
@pedrolamas
pedrolamas requested a lite review from Copilot August 18, 2026 18:49
@pedrolamas pedrolamas added the FR - Enhancement New feature or request label Aug 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a lightweight Docker health check for Fluidd’s NGINX-based images by introducing a /healthz endpoint and wiring a Dockerfile HEALTHCHECK to poll it, with accompanying docs and CI tweaks.

Changes:

  • Add location = /healthz in the NGINX config template returning 200 with plain-text ok.
  • Add a Docker image HEALTHCHECK that polls http://127.0.0.1:${PORT}/healthz, and plumb PORT via build args/env.
  • Update build workflow to pass PORT as a Docker build-arg (removing the prior sed-based template rewrite) and document the new health check.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
server/nginx/default.conf.template Adds /healthz endpoint for local health probing.
Dockerfile Introduces PORT env and Docker HEALTHCHECK polling /healthz.
.github/workflows/build.yml Removes template rewrite step; passes PORT build-arg for image variants.
docs/docs/getting-started.md Documents the health check and Compose service_healthy usage.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread Dockerfile Outdated
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

@pedrolamas
pedrolamas merged commit 94ea4ea into fluidd-core:develop Aug 18, 2026
6 checks passed
@pedrolamas
pedrolamas deleted the pedrolamas/docker-healthcheck branch August 18, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FR - Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants