Repository navigation
feat: build the MPEG-4 Visual reference decoder (vm_dec) - #413
rsanchez87 wants to merge 1 commit into
Conversation
5ad89a5 to
0c7d66c
Compare
It should be enabled for other platforms and tested in the CI |
fd0b62e to
4e3dbbc
Compare
Done, tested here https://github.com/fluendo/fluster/actions/runs/40315200021 |
Enabled by default like the other reference decoders (-Dmpeg4_video_decoder=false to disable). download_deps.py fetches the ISO sources and adapts them to current compilers; no ISO code is committed. Built in CI on Linux (x86_64, ARM64), macOS (ARM64) and Windows (MSYS2)
4e3dbbc to
b05b7c5
Compare
| 'MPEG-2 video decoder': build_mpeg2_video, | ||
| 'MPEG-2 AAC decoder': build_mpeg2_aac, | ||
| 'MPEG-H 3D Audio decoder': build_mpegh, | ||
| 'MPEG-4 Visual decoder': build_mpeg4_video, |
There was a problem hiding this comment.
This should go into the 'ISO Reference Decoders (MPEG-4 AAC only)' section
| # The zip holds several implementations, only this one produces vm_dec | ||
| implementation = "microsoft-v2.5-040207-NTU/" | ||
|
|
||
| if mpeg4_video_dir.exists(): |
There was a problem hiding this comment.
If contrib/MPEG-4_video_refSoft already exists (interrupted run) shims/ is never created and the source rewrites are never applied. Future changes to build/compat/mpeg4video/ also won’t be copied into existing trees.
|
|
||
| print() | ||
| print("=== Building MPEG-4 Visual reference decoder (vm_dec) ===") | ||
| if shutil.which("make") is None: |
There was a problem hiding this comment.
I think I prefer having meson build the decoder like we are doing with the rest of decoders build creating our own wrap file and meson.build.
See for example mpeg2aac:
PR to try to solve this issue #348
Only tested on linux (x86_64)