Document the Fail2BanBlocked and Allow2BanBlocked events - #12
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Documents the newly added Fail2BanBlocked and Allow2BanBlocked PSR-14 events across the Phirewall documentation, clarifying what fires when a request is blocked due to an already-banned key.
Changes:
- Update Fail2Ban/Allow2Ban feature docs to describe and link the new “blocked-by-existing-ban” events.
- Extend observability and notification docs to include the new event classes and properties.
- Update architecture documentation to reflect the additional event dispatch points.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/features/fail2ban.md | Adds/links Fail2BanBlocked and Allow2BanBlocked event documentation and updates flow descriptions. |
| docs/advanced/track-notifications.md | Adds the new events to the consolidated event reference table. |
| docs/advanced/observability.md | Adds the new events to the event summary and documents their semantics; updates diagnostics category examples. |
| docs/advanced/architecture.md | Notes event dispatch behavior when requests are blocked due to existing bans. |
Comments suppressed due to low confidence (1)
docs/features/fail2ban.md:312
- Same formatting issue as the Fail2Ban diagram above: this first line no longer has the leading
|/indent used by the rest of the ASCII diagram, so the flowchart alignment is off.
Request --> Is key already banned? --> Yes --> 403 (Allow2BanBlocked event)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sascha-egerer
force-pushed
the
docs/blocked-events
branch
from
July 24, 2026 21:02
819e287 to
7ae8c39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.