Repository navigation
fix(flow-php/etl): empty sources without a declared schema fail at the source - #2696
Merged
Merged
Conversation
…e source - empty sources throw InferredSchemaException from schema() - reading an empty source under a declared schema yields 0 rows - parquet and floe accept withSchema(), files read by name - from_cache() without a cache is not derivable - upgrading notes and declared schema docs
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #2696 +/- ##
============================================
+ Coverage 90.04% 90.07% +0.02%
- Complexity 29453 29489 +36
============================================
Files 2212 2212
Lines 85683 85778 +95
============================================
+ Hits 77157 77261 +104
+ Misses 8526 8517 -9 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Added
flow-php/etl-adapter-parquet-from_parquet()->withSchema()reads every file by name against a declared schemaflow-php/etl-from_floe()->withSchema()reads every file by name against a declared schemaFixed
flow-php/etl- an empty source under a declared schema reads 0 rows instead of failing at plan timeChanged
flow-php/etl- an empty source without a declared schema throwsInferredSchemaExceptionflow-php/etl-from_cache()without a cache instance throwsSchemaNotDerivableExceptionflow-php/etl-adapter-csv,flow-php/etl-adapter-json,flow-php/etl-adapter-excel,flow-php/etl-adapter-google-sheet- an empty file, sheet or glob without a declared schema throwsInferredSchemaExceptionRemoved
Deprecated
Security