Repository navigation
fix(flow-php/telemetry): redact secrets from HTTP URLs and stack traces - #2695
Merged
Merged
Conversation
- redact userinfo and sensitive query values in url.full, url.query and exception messages - extend semconv default list with OAuth, API key and credential params - configurable list via url_sanitizer() and bundle sanitization config - record Symfony HttpClient effective URL - render exception.stacktrace without argument values - fix mago 1.58 analysis issues
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2695 +/- ##
=========================================
Coverage 90.04% 90.05%
- Complexity 29437 29453 +16
=========================================
Files 2209 2212 +3
Lines 85603 85683 +80
=========================================
+ Hits 77081 77159 +78
- Misses 8522 8524 +2 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
… trace leak tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Added
flow-php/telemetry-UrlSanitizerwithurl_sanitizer()DSLflow-php/telemetry-ClientUrlAttributesfor HTTP client span attributesflow-php/symfony-telemetry-bundle-instrumentation.sanitization.url.sensitive_query_parametersconfigFixed
flow-php/symfony-telemetry-bundle- HTTP client spans record the effective URL (base_uri,queryoption)Changed
flow-php/psr18-telemetry-bridge-PSR18TraceableClientaccepts aUrlSanitizerRemoved
Deprecated
Security
flow-php/telemetry-exception.stacktraceno longer carries function argument valuesflow-php/psr18-telemetry-bridge- credentials and sensitive query values redacted inurl.fulland exception messagesflow-php/symfony-telemetry-bundle- credentials and sensitive query values redacted inurl.full,url.queryand exception messages