Skip to content

Grid focus highlight improvements #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lawsie wants to merge 5 commits into
base: main
Choose a base branch
from
+18 −16
Open

Grid focus highlight improvements #628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
843b44d
Properly focus highlight material selection
lawsie May 14, 2026
8fe666c
Properly scroll on KB controls
lawsie May 14, 2026
4673ce7
Make add object focus clearer
lawsie May 14, 2026
6a3157c
Fix purple highlight in color picker
lawsie May 14, 2026
880dbc4
Change var
lawsie May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,15 +720,11 @@ button {
}

#shapes-dropdown ul li.keyboard-focused {
background-color: var(--color-bg-glass-focused);
box-shadow: 0 0 0 2px #007acc;
outline: 3px solid var(--color-outline-focus);
outline-offset: -3px;
border-radius: 5px;
}

#shapes-dropdown ul li.keyboard-focused img {
transform: scale(1.2);
}

/* Scrollable Container with Arrows */
.scrollable-container {
position: relative;
Expand Down
9 changes: 9 additions & 0 deletions style/blockly.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,6 +524,11 @@ body[data-theme="low-vision"] {
color: var(--color-menu-item-text) !important;
}

/* Fix offsetParent so the plugin's scroll-into-view logic targets the right container. */
.blocklyFieldGridContainer {
position: relative;
}

/* Ensure key labels in field_grid_dropdown are readable on light dropdowns. */
.blocklyFieldGrid .blocklyFieldGridItem {
color: #000000 !important;
Expand All @@ -537,6 +542,10 @@ body[data-theme="low-vision"] {
box-shadow: 0 0 0 4px #fff !important;
}

.blocklyFieldGrid .blocklyFieldGridItem:focus {
outline: 3px solid var(--color-outline-focus) !important;
}

body .blocklyHtmlInput {
font-family:
"Atkinson Hyperlegible Next", "Asap", Helvetica, Arial, Lucida, sans-serif !important;
Expand Down
17 changes: 7 additions & 10 deletions ui/colourpicker.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@
.color-picker-close:focus {
background: #f0f0f0;
color: #333;
outline: 3px solid #511d91;
outline: 3px solid var(--color-focus);
outline-offset: 2px;
}

Expand Down Expand Up @@ -655,7 +655,7 @@

.color-brightness:hover,
.color-brightness:focus {
outline: 3px solid #511d91;
outline: 3px solid var(--color-focus);
outline-offset: 2px;
transform: scale(1.02);
}
Expand Down Expand Up @@ -707,8 +707,7 @@
.advanced-toggle:hover,
.advanced-toggle:focus {
background: #e8e8e8;
border-color: #511d91;
outline: 3px solid #511d91;
outline: 3px solid var(--color-focus);
outline-offset: 2px;
}

Expand Down Expand Up @@ -752,7 +751,7 @@
}

.rgb-slider:focus {
outline: 3px solid #511d91;
outline: 3px solid var(--color-focus);
outline-offset: 2px;
}

Expand Down Expand Up @@ -788,9 +787,8 @@
}

.rgb-number:focus {
outline: 3px solid #511d91;
outline: 3px solid var(--color-focus);
outline-offset: 2px;
border-color: #511d91;
}

/* CSS input */
Expand All @@ -805,13 +803,12 @@
border-radius: 8px;
font-size: 16px;
font-family: monospace;
transition: all 0.2s ease;
transition: border-color 0.2s ease;
}

.css-color-input:focus {
outline: 3px solid #511d91;
outline: 3px solid var(--color-focus);
outline-offset: 2px;
border-color: #511d91;
}

/* Action buttons */
Expand Down
Loading