Skip to content

Fix races and memory leak in ReceptionStatusAwaiter#156

Merged
lfse-slafleur merged 3 commits into
flexiblepower:mainfrom
philipptrenz:fix-reception-status-awaiter
Jun 11, 2026
Merged

Fix races and memory leak in ReceptionStatusAwaiter#156
lfse-slafleur merged 3 commits into
flexiblepower:mainfrom
philipptrenz:fix-reception-status-awaiter

Conversation

@philipptrenz

Copy link
Copy Markdown
Contributor

This PR ensures that each ReceptionStatus will get removed after being consumed.

Resolves #153

@philipptrenz

Copy link
Copy Markdown
Contributor Author

@lfse-slafleur

@lfse-slafleur

Copy link
Copy Markdown
Member

@philipptrenz Thanks for pinging me! Sorry for the slow response after your ping, we were doing a task that was super high prio on our side.

@lfse-slafleur lfse-slafleur left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with approving this for now. Be aware that the life cycle of a ReceptionStatus still has to be designed in S2 so we will have to revisit this in the future, but at least with your PR we won't have an ever growing list.

Edge cases will remain after this fix e.g. being able to check if a ReceptionStatus has been received in the past, how long should we keep it (currently if a ReceptionStatus is never awaited, it will remain in ReceptionStatusAwaiter indefinitely as well).

We should release this with a major version bump, because it will change the usage of this library significantly. I don't know of anyone who is relying on being able to receive the same ReceptionStatus multiple times, but it might break idempotency for some of our users.

@lfse-slafleur lfse-slafleur merged commit ea46bde into flexiblepower:main Jun 11, 2026
19 checks passed
@lfse-slafleur

lfse-slafleur commented Jun 11, 2026

Copy link
Copy Markdown
Member

@philipptrenz Released as v0.10.0 Thank you for your contribution!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Races and memory leak for ReceptionStatusAwaiter

2 participants