Repository navigation
fix(sandbox): let substrate runs download newer Go toolchains - #172
adityathebe wants to merge 1 commit into
Conversation
A hosted Test run on flanksource/duty (go.mod: go 1.26.10) failed in every package before any test ran. The runner image has an older Go, so go fetched go1.26.10, and proxy.golang.org redirects toolchain downloads to storage.googleapis.com, which the sandbox's DNS and egress allowlist refused. Add storage.googleapis.com to DefaultSubstrateEgress. Passthrough admits all of Google Cloud Storage, which the comment next to the host notes. Fixes #171
|
No actionable comments were generated in the recent review. WalkthroughThe default substrate egress list now includes ChangesSubstrate egress
Suggested reviewers: Change: Bug fix · Severity of issue fixed: Medium Merge Risk:
|
Gavel summary
Totals: 8961 passed · 0 failed · 35 skipped · 24m28s |
Gavel summary
Totals: 4 passed · 1 failed · 2 skipped · 3m34s Failing lintersreact-doctor — 22 violation(s)
|
Hosted test runs fail before running any tests when a repo's
go.modrequires a newer Go than the runner image has. This lets the sandbox download that toolchain. Fixes #171.Opus 5.5 Medium
Trigger: a Test run on
flanksource/dutymain (5d890c4,go 1.26.10) failed in all 30 packages within a second, on substrate runcab9726a-7cbe-4bde-9051-c5c0ffd211d7.Root cause: the runner image ships Go 1.26.9, so
GOTOOLCHAIN=autodownloads go1.26.10.proxy.golang.orgredirects toolchain downloads tostorage.googleapis.com, which isn't inDefaultSubstrateEgress, so the sandbox's DNS returnedno such host.Fix: add
storage.googleapis.comtoDefaultSubstrateEgress, with a comment explaining why it's there. Egress is TLS passthrough, so this allows all of Google Cloud Storage, not only Go's toolchains; the comment says so.Verification: the existing
TestSubstrateBackendIsCaptainsSubstrateSandboxOptionsexpectation is updated; left to CI.Summary by CodeRabbit
storage.googleapis.comon port 443 in the default egress host list.