Repository navigation
fix(test): the TERM-ignoring service is ready only once its child's pid is written - #170
Open
yashmehrotra wants to merge 2 commits into
Open
yashmehrotra wants to merge 2 commits into
yashmehrotra wants to merge 2 commits into
Conversation
…id is written The service's child writes the ready file and its shell writes the child's pid file, racing each other, but readiness waited only for the ready file. When the child won, execute returned and the spec read a pid file that didn't exist yet: "open .../child.pid: no such file or directory" in CI. Readiness now waits for both.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Contributor
Gavel summary
Totals: 8961 passed · 0 failed · 35 skipped · 18m57s |
Contributor
Gavel summary
Totals: 4 passed · 1 failed · 2 skipped · 2m25s Failing lintersreact-doctor — 22 violation(s)
|
…ream the fast pass The spec required the fast test's streamed pass to arrive over 500ms before vitest exited, with the slow test sleeping 1.5s. On a loaded CI runner vitest delivered both results together and the gap was 141ms. The slow test now passes only once gavel has streamed the fast test's pass, which writes a marker file the slow test waits for, up to 30s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The service's child writes the ready file and its shell writes the child's pid file, racing each other, but readiness waited only for the ready file. When the child won, execute returned and the spec read a pid file that didn't exist yet: "open .../child.pid: no such file or directory" in CI. Readiness now waits for both.