Skip to content

fix(test): the TERM-ignoring service is ready only once its child's pid is written - #170

Open
yashmehrotra wants to merge 2 commits into
mainfrom
platform-review-fixes
Open

yashmehrotra wants to merge 2 commits into
mainfrom
platform-review-fixes

Conversation

@yashmehrotra

Copy link
Copy Markdown
Member

The service's child writes the ready file and its shell writes the child's pid file, racing each other, but readiness waited only for the ready file. When the child won, execute returned and the spec read a pid file that didn't exist yet: "open .../child.pid: no such file or directory" in CI. Readiness now waits for both.

…id is written

The service's child writes the ready file and its shell writes the child's
pid file, racing each other, but readiness waited only for the ready file.
When the child won, execute returned and the spec read a pid file that
didn't exist yet: "open .../child.pid: no such file or directory" in CI.
Readiness now waits for both.
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ad822d86-ed73-4164-be15-542c370c88a8
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Gavel summary

Source Pass Fail Skip Duration
./pr/ui 1514 0 1 1m46s
./site 23 0 0 1.5s
./testrunner/ui 116 0 0 11.8s
ai 2 0 0 702.63µs
archtest 15 0 0 1m0s
azuredevops 68 0 0 58ms
baseline 18 0 0 341.195µs
betterleaks 3 0 0 84ms
branchmerge 25 0 0 2.6s
browser 19 0 2 17.7s
bulk 13 0 0 991.845µs
cache 8 0 0 1.6s
changegraph 8 0 0 452ms
changeset 27 0 0 2.2s
commands 11 0 0 628ms
commit 179 0 0 5.1s
create 34 0 0 6.3s
database 19 0 0 14.5s
entity 41 0 0 7ms
fixturebenchtest 2 0 0 1ms
fixtures 239 0 5 17.2s
gavel 188 0 0 1m9s
ginkgoscope 3 0 0 134ms
git 258 0 3 13.7s
github 24 0 0 2.8s
github.com/flanksource/gavel 1 0 0 1.2s
github.com/flanksource/gavel/ai 14 0 0 160ms
github.com/flanksource/gavel/ai/aifix 13 0 0 20ms
github.com/flanksource/gavel/ai/prfix 17 0 0 2.3s
github.com/flanksource/gavel/api 94 0 0 35.0s
github.com/flanksource/gavel/blob 38 0 2 -
github.com/flanksource/gavel/chart 16 0 0 6.7s
github.com/flanksource/gavel/claudehistory 16 0 0 -
github.com/flanksource/gavel/cmd/gavel 383 0 1 2m13s
github.com/flanksource/gavel/cmd/gavel/choose 18 0 0 -
github.com/flanksource/gavel/commit 291 0 0 22.2s
github.com/flanksource/gavel/context 3 0 0 -
github.com/flanksource/gavel/examples/sample-app 2 0 0 -
github.com/flanksource/gavel/fixtures 202 0 0 7.5s
github.com/flanksource/gavel/fixtures/types 30 0 0 200ms
github.com/flanksource/gavel/git 68 0 0 430ms
github.com/flanksource/gavel/github 210 0 2 2.0s
github.com/flanksource/gavel/github/activity 8 0 0 10ms
github.com/flanksource/gavel/github/cache 87 0 6 6.2s
github.com/flanksource/gavel/github/installations 5 0 0 10.6s
github.com/flanksource/gavel/internal/cache 2 0 0 4.2s
github.com/flanksource/gavel/internal/database 45 0 0 54.6s
github.com/flanksource/gavel/internal/logtest 2 0 0 -
github.com/flanksource/gavel/internal/retention 5 0 0 7.3s
github.com/flanksource/gavel/internal/streamtee 6 0 0 -
github.com/flanksource/gavel/internal/taskhistory 1 0 0 690ms
github.com/flanksource/gavel/internal/ttyrender 16 0 0 -
github.com/flanksource/gavel/lint 52 0 0 420ms
github.com/flanksource/gavel/linters 67 0 0 350ms
github.com/flanksource/gavel/linters/betterleaks 14 0 0 80ms
github.com/flanksource/gavel/linters/golangci 2 0 0 -
github.com/flanksource/gavel/linters/jscpd 23 0 0 -
github.com/flanksource/gavel/linters/oxlint 15 0 0 -
github.com/flanksource/gavel/linters/reactdoctor 18 0 0 -
github.com/flanksource/gavel/linters/tsc 12 0 0 70ms
github.com/flanksource/gavel/missioncontrol 10 0 2 -
github.com/flanksource/gavel/modelkeys 9 0 0 6.6s
github.com/flanksource/gavel/models 1 0 0 -
github.com/flanksource/gavel/platform 7 0 0 5.6s
github.com/flanksource/gavel/pr/ui 446 0 4 46.0s
github.com/flanksource/gavel/procfile 7 0 0 -
github.com/flanksource/gavel/prompts/registry 9 0 0 540ms
github.com/flanksource/gavel/prwatch 117 0 0 -
github.com/flanksource/gavel/report 8 0 0 -
github.com/flanksource/gavel/sandbox 67 0 6 12.6s
github.com/flanksource/gavel/sandbox/credentialprovider 9 0 0 220ms
github.com/flanksource/gavel/sandbox/runclient 6 0 0 -
github.com/flanksource/gavel/service 46 0 0 4.5s
github.com/flanksource/gavel/snapshots 29 0 0 2.5s
github.com/flanksource/gavel/sshkeys 2 0 0 1.4s
github.com/flanksource/gavel/status 60 0 0 680ms
github.com/flanksource/gavel/tenant 3 0 0 -
github.com/flanksource/gavel/testrunner 158 0 0 10.2s
github.com/flanksource/gavel/testrunner/bench 12 0 0 -
github.com/flanksource/gavel/testrunner/history 7 0 0 -
github.com/flanksource/gavel/testrunner/parsers 111 0 0 70ms
github.com/flanksource/gavel/testrunner/runners 76 0 0 100ms
github.com/flanksource/gavel/testrunner/ui 51 0 0 120ms
github.com/flanksource/gavel/testrunner/uirexport 21 0 0 1.4s
github.com/flanksource/gavel/testrunner/uirplan 3 0 0 30ms
github.com/flanksource/gavel/todos 59 0 0 10ms
github.com/flanksource/gavel/todos/bulk 17 0 0 -
github.com/flanksource/gavel/todos/content 1 0 0 -
github.com/flanksource/gavel/todos/entity 16 0 0 -
github.com/flanksource/gavel/todos/labels 70 0 0 -
github.com/flanksource/gavel/todos/native 86 0 0 15.6s
github.com/flanksource/gavel/todos/ops 15 0 0 -
github.com/flanksource/gavel/todos/portable 7 0 0 990ms
github.com/flanksource/gavel/todos/prompt 52 0 0 250ms
github.com/flanksource/gavel/todos/query 31 0 0 -
github.com/flanksource/gavel/todos/remote 3 0 0 2.5s
github.com/flanksource/gavel/todos/runtime 52 0 0 7.1s
github.com/flanksource/gavel/todos/types 97 0 0 -
github.com/flanksource/gavel/todosync 3 0 0 -
github.com/flanksource/gavel/utils 51 0 0 -
github.com/flanksource/gavel/verify 116 0 0 70ms
githubpush 35 0 0 925.662µs
gitstate 59 0 0 1m21s
jira 8 0 0 682.4µs
jsonb 8 0 0 519.078µs
kubernetes 43 0 0 4ms
labels 32 0 0 634.222µs
land 14 0 0 11.9s
library 16 0 0 209ms
lifecycle 303 0 0 1.9s
lint 18 0 0 2.7s
linters 9 0 0 3ms
merge 31 0 0 106ms
native 75 0 0 24.1s
ops 17 0 0 704.531µs
outline 56 0 0 46ms
parsers 38 0 0 12ms
processruntime 9 0 0 334.162µs
procfile 67 0 0 34.9s
prompt 55 0 0 254ms
provider 13 0 0 1.1s
prwatch 54 0 0 9ms
query 13 0 0 318.258µs
registry 11 0 0 19ms
run 33 0 0 26ms
runcache 11 0 0 381ms
runners 11 0 0 3.4s
runtime 106 0 0 9.7s
safefs 3 0 0 3ms
serve 45 0 0 3.0s
service 4 0 0 279.663µs
services 44 0 1 32.7s
shims 37 0 0 11ms
snapshots 2 0 0 1ms
status 3 0 0 93ms
taskhistory 7 0 0 720ms
testrunner 48 0 0 43.0s
todo 24 0 0 39ms
todoprojection 20 0 0 4.5s
todos 59 0 0 913ms
tools 14 0 0 1.3s
traces 13 0 0 2.1s
types 72 0 0 568ms
ui 562 0 0 2m7s
utils 118 0 0 292ms
verifier 34 0 0 223ms
verify 91 0 0 118ms
vitedev 4 0 0 4ms
workspace 8 0 0 1ms

Totals: 8961 passed · 0 failed · 35 skipped · 18m57s

View full results

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Gavel summary

Source Pass Fail Skip Duration
lint: react-doctor 2 1 0 13.2s
lint: betterleaks 0 0 1 -
lint: golangci-lint 1 0 0 2m12s
lint: oxlint 1 0 0 474ms
lint: tsc 0 0 1 -

Totals: 4 passed · 1 failed · 2 skipped · 2m25s

Failing linters

react-doctor — 22 violation(s)

  • src/components/platform/BudgetsPanel.tsx:87 — Array index used as a key: Your users can see & submit the wrong data when this list reorders or filters, so use a stable id like key={item.id}, not the array index "i". Use a stable id from the ... (react-doctor)
  • src/components/platform/CaptainHistoryPanel.tsx:129 — Array index used as a key: Your users can see & submit the wrong data when this list reorders or filters, so use a stable id like key={item.id}, not the array index "i". Use a stable id from the ... (react-doctor)
  • src/components/platform/InfrastructurePanel.tsx:130 — Array index used as a key: Your users can see & submit the wrong data when this list reorders or filters, so use a stable id like key={item.id}, not the array index "i". Use a stable id from the ... (react-doctor)
  • src/components/platform/ModelUsagePanel.tsx:5 — Heavy library loaded eagerly: "recharts" ships extra code to your users up front & slows page load. Load it on demand with React.lazy() or next/dynamic. Load it only when needed: `const Component =... (react-doctor)
  • src/components/platform/ModelUsagePanel.tsx:97 — Array index used as a key: Your users can see & submit the wrong data when this list reorders or filters, so use a stable id like key={item.id}, not the array index "i". Use a stable id from the ... (react-doctor)
  • ... and 17 more violations

View full results

…ream the fast pass

The spec required the fast test's streamed pass to arrive over 500ms before
vitest exited, with the slow test sleeping 1.5s. On a loaded CI runner
vitest delivered both results together and the gap was 141ms. The slow
test now passes only once gavel has streamed the fast test's pass, which
writes a marker file the slow test waits for, up to 30s.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant