Skip to content

fix(serve): unblock token mints and trim repeated Clerk and substrate calls on the platform dashboard - #163

Merged
moshloop merged 3 commits into
mainfrom
platform-review-fixes
Nov 18, 2026
Merged

moshloop merged 3 commits into
mainfrom
platform-review-fixes

Conversation

@yashmehrotra

Copy link
Copy Markdown
Member

No description provided.

…tallation

InstallationToken held the App's lock across the call to GitHub, so while
one installation's mint waited on GitHub (up to the client's 20s timeout)
every caller waited, even those with a cached token. The lock now guards
only the cache.
…or a minute

Every load of the tenants panel paged through all of the Clerk instance's
organizations, 100 a page, so with many organizations each reload made
dozens of Backend API calls against Clerk's rate limit. The list is kept
for a minute; a failed read isn't kept.
…ecutor's connection

With --sandbox substrate, hosted serve dialed substrate twice with the same
options: once for the executor and once for the platform dashboard's
inventory. The substrate executor now lists workers and actors itself, and
serve hands it to the platform API the way it hands it to the sweeper.
@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 41fb8d2a-092a-483c-8985-231eb534d029
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

Copy link
Copy Markdown
Contributor

Gavel summary

Source Pass Fail Skip Duration
./pr/ui 1514 0 1 2m23s
./site 23 0 0 2.5s
./testrunner/ui 116 0 0 14.0s
ai 2 0 0 702.63µs
archtest 15 0 0 1m25s
azuredevops 68 0 0 58ms
baseline 18 0 0 341.195µs
betterleaks 3 0 0 98ms
branchmerge 25 0 0 3.2s
browser 19 0 2 31.1s
bulk 13 0 0 991.845µs
cache 8 0 0 1.6s
changegraph 8 0 0 241ms
changeset 27 0 0 3.9s
commands 11 0 0 1.0s
commit 179 0 0 3.0s
create 34 0 0 2.8s
database 19 0 0 35.3s
entity 41 0 0 7ms
fixturebenchtest 2 0 0 1ms
fixtures 239 0 5 18.4s
gavel 188 0 0 1m30s
ginkgoscope 3 0 0 131ms
git 258 0 3 20.8s
github 24 0 0 2.8s
github.com/flanksource/gavel 1 0 0 1.9s
github.com/flanksource/gavel/ai 14 0 0 160ms
github.com/flanksource/gavel/ai/aifix 13 0 0 20ms
github.com/flanksource/gavel/ai/prfix 17 0 0 1.9s
github.com/flanksource/gavel/api 94 0 0 35.0s
github.com/flanksource/gavel/blob 38 0 2 -
github.com/flanksource/gavel/chart 16 0 0 8.2s
github.com/flanksource/gavel/claudehistory 16 0 0 -
github.com/flanksource/gavel/cmd/gavel 383 0 1 2m44s
github.com/flanksource/gavel/cmd/gavel/choose 18 0 0 -
github.com/flanksource/gavel/commit 291 0 0 15.8s
github.com/flanksource/gavel/context 3 0 0 -
github.com/flanksource/gavel/examples/sample-app 2 0 0 -
github.com/flanksource/gavel/fixtures 202 0 0 7.2s
github.com/flanksource/gavel/fixtures/types 30 0 0 80ms
github.com/flanksource/gavel/git 68 0 0 600ms
github.com/flanksource/gavel/github 210 0 2 2.4s
github.com/flanksource/gavel/github/activity 8 0 0 10ms
github.com/flanksource/gavel/github/cache 87 0 6 6.2s
github.com/flanksource/gavel/github/installations 5 0 0 9.2s
github.com/flanksource/gavel/internal/cache 2 0 0 4.2s
github.com/flanksource/gavel/internal/database 45 0 0 1m8s
github.com/flanksource/gavel/internal/logtest 2 0 0 -
github.com/flanksource/gavel/internal/retention 5 0 0 7.3s
github.com/flanksource/gavel/internal/streamtee 6 0 0 -
github.com/flanksource/gavel/internal/taskhistory 1 0 0 690ms
github.com/flanksource/gavel/internal/ttyrender 16 0 0 -
github.com/flanksource/gavel/lint 52 0 0 430ms
github.com/flanksource/gavel/linters 67 0 0 220ms
github.com/flanksource/gavel/linters/betterleaks 14 0 0 120ms
github.com/flanksource/gavel/linters/golangci 2 0 0 -
github.com/flanksource/gavel/linters/jscpd 23 0 0 -
github.com/flanksource/gavel/linters/oxlint 15 0 0 -
github.com/flanksource/gavel/linters/reactdoctor 18 0 0 -
github.com/flanksource/gavel/linters/tsc 12 0 0 80ms
github.com/flanksource/gavel/missioncontrol 10 0 2 -
github.com/flanksource/gavel/modelkeys 9 0 0 6.6s
github.com/flanksource/gavel/models 1 0 0 -
github.com/flanksource/gavel/platform 7 0 0 5.6s
github.com/flanksource/gavel/pr/ui 446 0 4 1m45s
github.com/flanksource/gavel/procfile 7 0 0 -
github.com/flanksource/gavel/prompts/registry 9 0 0 540ms
github.com/flanksource/gavel/prwatch 117 0 0 -
github.com/flanksource/gavel/report 8 0 0 -
github.com/flanksource/gavel/sandbox 67 0 6 34.0s
github.com/flanksource/gavel/sandbox/credentialprovider 9 0 0 220ms
github.com/flanksource/gavel/sandbox/runclient 6 0 0 -
github.com/flanksource/gavel/service 46 0 0 4.5s
github.com/flanksource/gavel/snapshots 29 0 0 3.3s
github.com/flanksource/gavel/sshkeys 2 0 0 1.4s
github.com/flanksource/gavel/status 60 0 0 2.0s
github.com/flanksource/gavel/tenant 3 0 0 -
github.com/flanksource/gavel/testrunner 158 0 0 15.5s
github.com/flanksource/gavel/testrunner/bench 12 0 0 -
github.com/flanksource/gavel/testrunner/history 7 0 0 -
github.com/flanksource/gavel/testrunner/parsers 111 0 0 210ms
github.com/flanksource/gavel/testrunner/runners 76 0 0 180ms
github.com/flanksource/gavel/testrunner/ui 51 0 0 130ms
github.com/flanksource/gavel/testrunner/uirexport 21 0 0 2.9s
github.com/flanksource/gavel/testrunner/uirplan 3 0 0 10ms
github.com/flanksource/gavel/todos 59 0 0 40ms
github.com/flanksource/gavel/todos/bulk 17 0 0 -
github.com/flanksource/gavel/todos/content 1 0 0 -
github.com/flanksource/gavel/todos/entity 16 0 0 -
github.com/flanksource/gavel/todos/labels 70 0 0 -
github.com/flanksource/gavel/todos/native 86 0 0 15.6s
github.com/flanksource/gavel/todos/ops 15 0 0 -
github.com/flanksource/gavel/todos/portable 7 0 0 990ms
github.com/flanksource/gavel/todos/prompt 52 0 0 250ms
github.com/flanksource/gavel/todos/query 31 0 0 -
github.com/flanksource/gavel/todos/remote 3 0 0 3.3s
github.com/flanksource/gavel/todos/runtime 52 0 0 10.3s
github.com/flanksource/gavel/todos/types 97 0 0 -
github.com/flanksource/gavel/todosync 3 0 0 -
github.com/flanksource/gavel/utils 51 0 0 -
github.com/flanksource/gavel/verify 116 0 0 190ms
githubpush 35 0 0 925.662µs
gitstate 59 0 0 1m40s
jira 8 0 0 682.4µs
jsonb 8 0 0 519.078µs
kubernetes 43 0 0 29ms
labels 32 0 0 1ms
land 14 0 0 11.9s
library 16 0 0 255ms
lifecycle 303 0 0 2.6s
lint 18 0 0 1.9s
linters 9 0 0 4ms
merge 31 0 0 106ms
native 75 0 0 24.1s
ops 17 0 0 704.531µs
outline 56 0 0 108ms
parsers 38 0 0 37ms
processruntime 9 0 0 334.162µs
procfile 67 0 0 34.9s
prompt 55 0 0 254ms
provider 13 0 0 643ms
prwatch 54 0 0 9ms
query 13 0 0 318.258µs
registry 11 0 0 19ms
run 33 0 0 26ms
runcache 11 0 0 753ms
runners 11 0 0 12.1s
runtime 106 0 0 14.1s
safefs 3 0 0 1ms
serve 45 0 0 3.6s
service 4 0 0 362.103µs
services 44 0 1 42.6s
shims 37 0 0 12ms
snapshots 2 0 0 2ms
status 3 0 0 127ms
taskhistory 7 0 0 720ms
testrunner 48 0 0 1m4s
todo 24 0 0 39ms
todoprojection 20 0 0 4.5s
todos 59 0 0 2.3s
tools 14 0 0 1.3s
traces 13 0 0 2.6s
types 72 0 0 466ms
ui 562 0 0 2m9s
utils 118 0 0 384ms
verifier 34 0 0 205ms
verify 91 0 0 188ms
vitedev 4 0 0 6ms
workspace 8 0 0 1ms

Totals: 8961 passed · 0 failed · 35 skipped · 24m23s

View full results

@github-actions

Copy link
Copy Markdown
Contributor

Gavel summary

Source Pass Fail Skip Duration
lint: react-doctor 2 1 0 19.0s
lint: betterleaks 0 0 1 -
lint: golangci-lint 1 0 0 2m47s
lint: oxlint 1 0 0 628ms
lint: tsc 0 0 1 -

Totals: 4 passed · 1 failed · 2 skipped · 3m7s

Failing linters

react-doctor — 22 violation(s)

  • src/components/platform/BudgetsPanel.tsx:87 — Array index used as a key: Your users can see & submit the wrong data when this list reorders or filters, so use a stable id like key={item.id}, not the array index "i". Use a stable id from the ... (react-doctor)
  • src/components/platform/CaptainHistoryPanel.tsx:129 — Array index used as a key: Your users can see & submit the wrong data when this list reorders or filters, so use a stable id like key={item.id}, not the array index "i". Use a stable id from the ... (react-doctor)
  • src/components/platform/InfrastructurePanel.tsx:130 — Array index used as a key: Your users can see & submit the wrong data when this list reorders or filters, so use a stable id like key={item.id}, not the array index "i". Use a stable id from the ... (react-doctor)
  • src/components/platform/ModelUsagePanel.tsx:5 — Heavy library loaded eagerly: "recharts" ships extra code to your users up front & slows page load. Load it on demand with React.lazy() or next/dynamic. Load it only when needed: `const Component =... (react-doctor)
  • src/components/platform/ModelUsagePanel.tsx:97 — Array index used as a key: Your users can see & submit the wrong data when this list reorders or filters, so use a stable id like key={item.id}, not the array index "i". Use a stable id from the ... (react-doctor)
  • ... and 17 more violations

View full results

@moshloop
moshloop merged commit 309b76d into main Nov 18, 2026
11 of 12 checks passed
@moshloop
moshloop deleted the platform-review-fixes branch November 18, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants