Skip to content

chore(deps): Bump deps, gomplate v4 - #240

Open
moshloop wants to merge 3 commits into
mainfrom
chore/bump-deps-gomplate-v4-dmwvuhtuk0s8
Open

moshloop wants to merge 3 commits into
mainfrom
chore/bump-deps-gomplate-v4-dmwvuhtuk0s8

Conversation

@moshloop

@moshloop moshloop commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

What

  • Bump Go toolchain to 1.27.4 and update direct and indirect modules (ginkgo, gomega, testify, oops, xmlquery/xpath stack)
  • Migrate CEL from github.com/google/cel-go to cel.dev/cel-go
  • Migrate gomplate from v3 to v4 across filters, middleware, and tests
  • Drop unused cert-manager, gateway-api, and apiextensions-apiserver indirect requirements

Why

  • Keep dependencies current and remove unused requirements

Notes

  • Breaking: consumers importing github.com/flanksource/gomplate/v3 or github.com/google/cel-go must switch to gomplate/v4 and cel.dev/cel-go

Summary by CodeRabbit

  • Chores
    • Updated the Go toolchain and refreshed supporting libraries used by the application and its examples.
    • Updated the expression-evaluation and template-processing components.
    • No user-facing behavior changes are noted in this update.

…o v4

Upgrade the Go toolchain to 1.27.4 and bump direct and indirect modules, including ginkgo, gomega, testify, oops, and the xmlquery/xpath stack. Move CEL usage from github.com/google/cel-go to cel.dev/cel-go and gomplate from v3 to v4 across filters, middleware, and tests. Drop unused cert-manager, gateway-api, and apiextensions-apiserver indirect requirements.

BREAKING CHANGE: consumers importing github.com/flanksource/gomplate/v3 or github.com/google/cel-go must switch to gomplate/v4 and cel.dev/cel-go.

Claude-Session-Id: cd49c5e0-4ae9-4347-9830-9badc3d2b9a7
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 48 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4ccdfd4b-b405-4382-9109-6fb4b2a4064f
Commits

Reviewing files that changed from the base of the PR and between 65253ae and 76ec8f9.

Files selected for processing: 5

  • aichat/go.mod
  • examples/enitity/go.mod
  • examples/uber_demo/go.mod
  • telltale/go.mod
  • valkey/go.mod

No actionable comments were generated in the recent review.

Walkthrough

Go versions and dependency requirements change across the root and submodules. Source imports and dependency checks also change to use the cel.dev/cel-go and gomplate v4 module paths.

Changes

Go dependency and import updates

Layer / File(s) Summary
Update module requirements
go.mod, aichat/go.mod, examples/enitity/go.mod, examples/go.mod, examples/uber_demo/go.mod, telltale/go.mod, valkey/go.mod
The module files update Go versions and dependency requirements. Changes include dependency upgrades, CEL module path updates, gomplate v4, and removal of several indirect requirements.
Update CEL and gomplate imports
api/filter/celfilter/celfilter.go, api/filter/gomplatefilter/gomplatefilter.go, middleware/cel.go, task/task_fixture_test.go
CEL imports use the cel.dev/cel-go path. Gomplate imports use v4.
Align dependency checks
api/wasmtest/deps_test.go, dependency_closure_ginkgo_test.go
Dependency checks now use cel.dev/cel-go instead of github.com/google/cel-go.

Suggested reviewers: flanksource

Change: Other

Merge Risk: Minimal · previous review 65253

This updates the Go toolchain and dependencies and moves CEL and gomplate to their new module paths. No concrete problems were found, so the change looks safe to merge once CI passes. Downstream consumers must switch to the new import paths.

Pre-merge checks: Passed 3 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Description check Inconclusive The description follows the required structure only partly. It has a Description-like "What" and "Why" section and a Breaking note, but it omits the required template sections: Type of Change, Testing… Add the missing template sections: mark the Type of Change (this is a breaking change because consumers must migrate imports), complete the Testing section (state whether tests and the CLI were run), complete or confirm the Checklist items,…
Passed Passed checks: 3 passed

Check name Status Explanation
Title check Passed The title "chore(deps): Bump deps, gomplate v4" names the two main parts of the changeset: dependency bumps and the gomplate v3 to v4 migration. The changeset also moves CEL to cel.dev/cel-go and drop…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "chore(deps): Bump deps, gomplate v4" names the two main parts of the changeset: dependency bumps and the gomplate v3 to v4 migration. The changeset also moves CEL to cel.dev/cel-go and drops unused indirect requirements, which the title does not mention. The title is concise and specific enough for a teammate scanning history.

Full details: Description check

Explanation

The description follows the required structure only partly. It has a Description-like "What" and "Why" section and a Breaking note, but it omits the required template sections: Type of Change, Testing, Checklist, Breaking Changes (as a dedicated section with migration path), and Additional Notes. The Breaking note gives an impact statement and a basic migration path, which covers part of the breaking-changes requirement. The author did not mark any testing items, and the description does not state that tests were run.

Resolution

Add the missing template sections: mark the Type of Change (this is a breaking change because consumers must migrate imports), complete the Testing section (state whether tests and the CLI were run), complete or confirm the Checklist items, expand the Breaking Changes section with the migration path, and add any Additional Notes. Keep the existing What, Why, and Notes content.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e0defce7-6b98-4ba1-8f89-2d44d803f619
Commits

Reviewing files that changed from the base of the PR and between d171c99 and 65253ae.

Files ignored due to path filters: 4

  • examples/go.sum is excluded by !**/*.sum
  • examples/uber_demo/go.sum is excluded by !**/*.sum
  • telltale/go.sum is excluded by !**/*.sum
  • valkey/go.sum is excluded by !**/*.sum
Files selected for processing: 4

  • examples/go.mod
  • examples/uber_demo/go.mod
  • telltale/go.mod
  • valkey/go.mod

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Gavel summary

Source Pass Fail Skip Duration
lint: betterleaks 0 0 1 -
lint: golangci-lint 1 0 0 1m36s
lint: oxlint 1 0 0 140ms
lint: react-doctor 1 0 0 4.8s
lint: tsc 0 0 1 -

Totals: 3 passed · 0 failed · 2 skipped · 1m41s

View full results

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Gavel summary

Source Pass Fail Skip Duration
aichat 26 0 0 2ms
api 342 0 0 19ms
cache 28 0 0 119ms
celfilter 15 0 9 40ms
clicky 133 0 0 58.3s
clirender 18 0 0 577.052µs
enitity 1 0 0 5.1s
entity 171 0 0 133ms
entitydemo 1 0 0 1ms
excel 37 0 0 108ms
exec 156 0 1 13.5s
extensions 1 0 0 97.389µs
filter 10 0 3 355.001µs
flags 45 0 0 1ms
formatters 86 0 0 6ms
github.com/flanksource/clicky 28 0 0 2.9s
github.com/flanksource/clicky/api 258 0 0 160ms
github.com/flanksource/clicky/api/tailwind 434 0 0 -
github.com/flanksource/clicky/api/wasmtest 1 0 0 60ms
github.com/flanksource/clicky/cmd/clicky 4 0 0 10ms
github.com/flanksource/clicky/docs 19 0 0 10ms
github.com/flanksource/clicky/entity 153 0 0 -
github.com/flanksource/clicky/examples/enitity/internal/entitydemo 7 0 0 -
github.com/flanksource/clicky/exec 3 0 0 320ms
github.com/flanksource/clicky/flags 53 0 0 10ms
github.com/flanksource/clicky/formatters 77 0 1 20ms
github.com/flanksource/clicky/formatters/http 38 0 0 -
github.com/flanksource/clicky/formatters/tests 201 0 1 10ms
github.com/flanksource/clicky/internal/gumchoose 2 0 0 -
github.com/flanksource/clicky/lint 13 0 0 -
github.com/flanksource/clicky/markdown 10 0 0 40ms
github.com/flanksource/clicky/mcp 102 0 0 2.1s
github.com/flanksource/clicky/middleware 31 0 0 -
github.com/flanksource/clicky/prompt 23 0 0 200ms
github.com/flanksource/clicky/route 12 0 0 -
github.com/flanksource/clicky/rpc 378 0 1 50ms
github.com/flanksource/clicky/rpc/http 8 0 0 10ms
github.com/flanksource/clicky/task 181 0 0 43.5s
github.com/flanksource/clicky/valkey 1 0 0 320ms
gomplatefilter 2 0 0 10ms
http 5 0 0 232.872µs
lint 16 0 0 7.9s
markdown 9 0 0 34ms
mcp 6 0 0 2ms
metrics 17 0 0 3.2s
middleware 38 0 0 6ms
process 46 0 0 1.6s
prompt 2 0 0 42ms
rpc 68 0 0 1.9s
schemaform 61 0 0 1.7s
sse 75 0 0 2.0s
table 4 0 0 273.923µs
task 176 0 0 17.3s
telltale 13 0 0 626ms
tests 11 0 47 3ms
text 78 0 0 303ms
urlfetch 4 0 0 1ms
valkey 46 0 0 310ms

Totals: 3784 passed · 0 failed · 63 skipped · 2m44s

View full results

…dencies

Bump the Go directive to 1.27.4 and update module dependencies (commons 1.64.2, ginkgo 2.33.1, gomega 1.44.0, testify 1.12.1, otel sdk 1.45.0, x/tools 0.52.0, x/mod 0.42.0, samber/oops 1.23.2 and others) across the examples, telltale and valkey modules. go.sum gains entries for cel-go, govalues/decimal and woodsbury/decimal128, and drops cert-manager, gateway-api and apiextensions-apiserver. gomplate moves from v3 to v4 in go.sum, so verify any gomplate imports still build.

Gavel-Issue-Id: eb49ce37-8f82-4450-8c34-aaa3a291dead
Claude-Session-Id: 01a1e83a-ee1d-7183-b5e4-d8dc8fe8c26d
…ss modules

Gavel-Issue-Id: eb49ce37-8f82-4450-8c34-aaa3a291dead
Claude-Session-Id: 01a1e83a-ee1d-7183-b5e4-d8dc8fe8c26d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant