Skip to content

chore: remove task-ui bundle, bump deps - #231

Merged
moshloop merged 11 commits into
mainfrom
chore/oipa-sync-20261022
Nov 1, 2026
Merged

moshloop merged 11 commits into
mainfrom
chore/oipa-sync-20261022

Conversation

@moshloop

@moshloop moshloop commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

What

  • Remove the task/ui Preact frontend and committed dist/taskui.js
  • Remove the dist and release bundle-rebuild jobs and the uber-demo task-ui command
  • Bump Go modules and the builder image to golang:1.27.3-alpine
  • Switch Playwright to github.com/mxschmitt/playwright-go
  • Replace glebarez/sqlite with clarkmcc/gorm-sqlite
  • Make process environment reads skip zombie and exiting processes, and add Snapshot.Children

Why

  • The embedded task-ui bundle was the only consumer of the CI rebuild workflows
  • Avoids a duplicate modernc sqlite driver registration at init

Notes

  • Breaking: the task/ui package (Handler, bundleJS), task.JSONHandler, and the uber-demo task-ui command are removed
  • Makefile no longer builds or cleans the task-ui bundle, and its .gitignore un-ignore rules are dropped

Summary by CodeRabbit

  • New Features
    • Added live metric streaming, including snapshots and updates as series change.
    • Spreadsheet column selectors can now choose a worksheet by name or position.
    • Added avatar rendering and task-scoped prompt visibility in task snapshots.
    • Optional boolean flags now distinguish between omitted, true, and false values.
  • Improvements
    • Improved Markdown and HTML rendering for text, lists, links, code, and rich values.
    • Task groups handle admission and concurrency changes more reliably.
  • Removals
    • Removed the built-in task progress web interface and its demo command.

Spreadsheet column flags can now pick a worksheet by name (Sheet!Column, with quoted names for spaces) or by one-based position (#2!Column), instead of always reading the first sheet. Pointer-to-bool fields now distinguish omitted, false and true across CLI and request inputs.
BREAKING CHANGE: SpreadsheetReader now takes a SpreadsheetReadOptions argument, so custom readers passed to SetSpreadsheetReader must update their signature.
…d terminal output

Literal text was emitted unescaped in HTML and Markdown, and list, link, and code output broke on special characters. Text, attributes, link destinations, and code fences are now escaped or sized to their content, and lists share one renderer across formats. Raw HTML is converted to plain text for terminal output.
BREAKING CHANGE: TextTable.HTML() now renders static markup unless Interactive is set, and expandable row details are no longer wrapped in Alpine.js templates.
Drop the explicit Metrics disable option so the task queue uses the default metrics setting and reports metrics again. This adds metric emission overhead and new series to dashboards. BREAKING CHANGE: the task queue now emits metrics by default, which may increase metric cardinality and resource usage.
Bump flanksource captain, commons, gomplate, commons-db and is-healthy to newer releases, and move the gavel CI action to v0.0.64. Several modules are also downgraded: charmbracelet/x/conpty to v0.1.0, glebarez/go-sqlite to v1.21.2, and go-test/deep to v1.0.3. New indirect deps include sqlglot-go, glebarez/sqlite, gorm sqlserver and pb33f/ordered-map. Unused indirect modules such as lmittmann/tint, shirou/gopsutil/v3 and the vadimi NTLM packages are removed. The webapp moves @flanksource/clicky-ui to 0.3.54, and format.go gains Avatar and KeyMap helpers. No public API is removed, so no breaking change is expected, but the downgrades should be verified against the affected code paths.
…s snapshot

Prompts raised inside a running task are now labeled with that task's id, so the task snapshot can list the questions it is blocked on. A nested task overwrites the label, so a prompt belongs to the innermost running task. Adds an optional TaskSnapshot.Prompts field (json prompts,omitempty); the change is additive and does not alter existing behavior.
…of polling

A member that could not take its group's permit was re-enqueued with a 50ms
delay. The queue only looks at its head, which is always the group's oldest
waiting member, so while it sat out the delay no worker could dequeue
anything: a bounded group drained about one member per 25ms whatever its
concurrency (2,000 members at concurrency 4 took ~55s).

Such a member now parks in the group's admission line, out of the queue, and
is handed back when a permit is released, the member ahead of it is admitted
or retires, or it is cancelled or its context ends.

Claude-Session-Id: 45e3588e-f94a-44ba-8624-b1eb77edf56c
Replace the semaphore with a worker limit: workers numbered at or above the current maximum take no tasks, so a lowered SetMaxConcurrent now takes effect. Workers are started on demand when the maximum is raised, and foregroundWorkersActive reads tm.workers under mu because the slice can grow. Also registers stream metrics routes under the tasks prefix.
…d append frames

Panels need one query per tick across many series. This adds SeriesSource, which answers many ids in one call, and Sources, which routes each id to a source by its prefix. GET metrics/stream sends a snapshot and then append frames over SSE, so one subscription serves a whole page of panels. Existing endpoints are not changed.
… workflows

The task/ui Preact frontend and its committed dist/taskui.js were go:embed'd and kept in sync by the dist and release workflows. Remove the package, both bundle-rebuild jobs, and the uber-demo task-ui command, since the embedded bundle was the only consumer. Also bumps example module dependencies and lockfiles, and switches the entity demo to ComposeSpecLayers. BREAKING CHANGE: the task/ui taskui package (Handler, bundleJS) is removed and the uber-demo task-ui command no longer exists.
…ui bundle

Bumps Go modules (golang.org/x/*, otel, commons-db, captain, gomplate-adjacent indirects) and the builder image to golang:1.27.3-alpine. Playwright now comes from github.com/mxschmitt/playwright-go, and glebarez/sqlite is replaced with clarkmcc/gorm-sqlite to avoid a duplicate modernc sqlite driver registration at init. Process environment reads now skip zombie and exiting processes and tolerate processes that exit mid-read, and Snapshot.Children is added. BREAKING CHANGE: task.JSONHandler is removed, and the task-ui frontend bundle is no longer built by make or cleaned up, and its go:embed un-ignore rules are dropped from .gitignore.
@moshloop
moshloop enabled auto-merge (rebase) November 1, 2026 10:15
@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Walkthrough

The PR removes the embedded task UI, changes task scheduling and prompt snapshots, adds a metrics series streaming API, and updates Markdown rendering, spreadsheet selection, process snapshots, the entity demo profile, build configuration, and dependencies.

Changes

Task UI removal

Layer / File(s) Summary
Remove task UI build and release wiring
.github/workflows/dist.yml, .github/workflows/release.yml, .gitignore, Makefile
The task UI bundle build and release-push steps are removed, along with related ignore and cleanup rules.
Remove task UI and demo command
task/ui/*, examples/uber_demo/main.go, examples/uber_demo/README.md, task/api.go
The embedded task UI and its frontend are deleted. The Uber demo task-ui command and the task JSON handler are removed.

Task execution and prompts

Layer / File(s) Summary
Worker limits and group admission
task/manager.go, task/worker.go, task/group_admission.go, task/task.go, task/manager_wait.go, task/*_ginkgo_test.go
Worker limits now control worker activity. Group admission parks tasks until they can start, and tests cover concurrency, throughput, and cancellation.
Task-scoped prompts and snapshots
prompt/sink.go, task/prompt.go, task/snapshot.go, task/prompt_ginkgo_test.go
Task execution adds task scope to prompt contexts. Running-task snapshots include pending prompts, with tests for resolution and nested tasks.

Metrics series streaming

Layer / File(s) Summary
Series contracts and source routing
metrics/series.go
Adds series request and response types, source routing, unknown-series errors, and a timeseries-store adapter.
SSE endpoint and task API registration
metrics/stream.go, metrics/stream_test.go, task/api.go
Adds a metrics SSE route that sends an initial snapshot and incremental changes. Task API registration mounts the route.

Markdown and rich-value rendering

Layer / File(s) Summary
Markdown serialization and parsing
internal/markdownutil/render.go, markdown/*
Adds shared Markdown escaping and delimiter helpers. Parsing and terminal rendering update text, whitespace, and HTML-node handling.
API text and structured-value rendering
api/*, format.go, formatters/*
Updates rich text, list, link, code, badge, avatar, table, and key-value rendering. Tests cover Markdown, HTML, Slack, and terminal output.

Flags and spreadsheet selectors

Layer / File(s) Summary
Optional boolean flag handling
flags/assignment.go, flags/binding.go, flags/parser.go, flags/request.go, flags/types.go, flags/optional_bool_ginkgo_test.go
Pointer-to-boolean fields now support omitted and explicit request and CLI values.
Worksheet selector parsing and reading
flags/spreadsheet_*.go, flags/assignment.go, formatters/excel/*
Spreadsheet selectors can choose a worksheet by name or index. The Excel reader validates selection and reads from that worksheet.

Process snapshots

Layer / File(s) Summary
Process lookup and environment capture
process/*
Adds direct-child lookup and selected-process environment capture, with handling for processes that have exited.

Entity demo profile

Layer / File(s) Summary
Compose runtime profile
examples/enitity/internal/entitydemo/serve_ui.go, examples/enitity/internal/entitydemo/serve_ui_ginkgo_test.go
The runtime profile now returns composed profile data and saved defaults. The test resolves the model from the composed trace.

Build and dependency updates

Layer / File(s) Summary
Workflow and build tool updates
.github/workflows/gavel.yml, Dockerfile
The Gavel action pin and Go builder image are updated.
Module and frontend dependency updates
go.mod, aichat/go.mod, examples/*/go.mod, valkey/go.mod, docs/site/package.json, examples/enitity/webapp/*
Module manifests update dependency versions and sets. Several manifests add or remove indirect dependencies and SQLite replacement mappings.

Sequence Diagram(s)

sequenceDiagram
  participant Client
  participant MetricsRoute
  participant SeriesSource
  Client->>MetricsRoute: Request metrics stream
  MetricsRoute->>SeriesSource: Query requested series
  SeriesSource-->>MetricsRoute: Return series and points
  MetricsRoute-->>Client: Send snapshot
  MetricsRoute->>SeriesSource: Query on each interval
  SeriesSource-->>MetricsRoute: Return updated series
  MetricsRoute-->>Client: Send appended points or removed IDs
Loading

Possibly related PRs

Suggested reviewers: flanksource

Change: Other

Merge Risk: Moderate · up to 08ff8

Downstream modules that import aichat can still hit a duplicate SQLite driver registration at startup, because the replace directive in aichat/go.mod is ignored outside that module. The entity demo can run chat with its default profile when a preset was requested. The new Playwright test never runs in the integration task. Markdown output can alter literal text in some edge cases. The first of these should be resolved or documented before merge.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

OSV Scanner (2.7.0)
aichat/go.mod

OSV Scanner exited with code 137 without a usable report

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​react-router-dom@​7.18.1 ⏵ 7.18.51001006592100
Updatednpm/​@​flanksource/​clicky-ui@​0.3.25 ⏵ 0.3.5467 -8100100 +196 +1100
Updatednpm/​@​radix-ui/​react-compose-refs@​1.1.3 ⏵ 1.1.5100 +110067 +189100
Updatednpm/​@​radix-ui/​react-slot@​1.3.0 ⏵ 1.5.0100 +110069 +198100
Updatedgolang/​github.com/​labstack/​echo/​v4@​v4.15.2 ⏵ v4.16.372 +1100 +75100100100
Updatedgolang/​github.com/​flanksource/​commons@​v1.59.0 ⏵ v1.63.072 +1100100100100
Updatedgolang/​golang.org/​x/​crypto@​v0.53.0 ⏵ v0.58.074 +1100100100100
Addedgolang/​github.com/​flanksource/​clicky@​v1.21.8274100100100100
Updatednpm/​@​ai-sdk/​react@​3.0.203 ⏵ 3.0.3239910075 +198100
Updatedgolang/​golang.org/​x/​tools@​v0.47.0 ⏵ v0.51.075 +1100100100100
Updatedgolang/​github.com/​flanksource/​captain@​v0.0.55 ⏵ v0.0.7175 +1100100100100
Updatedgolang/​go.opentelemetry.io/​otel@​v1.44.0 ⏵ v1.45.076 +1100100100100
Updatedgolang/​golang.org/​x/​text@​v0.40.0 ⏵ v0.43.077 +1100100100100
Updatednpm/​@​types/​react@​18.3.28 ⏵ 18.3.311001007990100
Addedgolang/​github.com/​mxschmitt/​playwright-go@​v0.6201.179100100100100
Updatednpm/​vite@​7.3.6 ⏵ 8.3.599 +1100 +2182 +196100
Updatednpm/​@​scalar/​api-reference-react@​0.9.31 ⏵ 0.9.87100 +110083 +3100100
Updatednpm/​iconify-icon@​3.0.2 ⏵ 3.0.49910010084 +3100
Updatednpm/​tailwindcss@​4.2.4 ⏵ 4.3.31001008497 -1100
Updatedgolang/​golang.org/​x/​sys@​v0.46.0 ⏵ v0.49.084 +1100100100100
Updatednpm/​@​tailwindcss/​vite@​4.2.4 ⏵ 4.3.3100 +110089 +197 -1100
Updatedgolang/​github.com/​flanksource/​gomplate/​v3@​v3.24.89 ⏵ v3.24.9089 +1100100100100
Updatednpm/​sharp@​0.35.4 ⏵ 0.35.597 +1100 +16100 +191100
Updatednpm/​oxlint@​1.72.0 ⏵ 1.90.0991009195 -1100
Updatednpm/​@​tanstack/​react-query@​5.101.4 ⏵ 5.105.09910091 +498100
Updatednpm/​streamdown@​2.5.0 ⏵ 2.7.199 +110010096100
Updatednpm/​react-grab@​0.1.47 ⏵ 0.1.5097 -210096 -396100
Updatedgolang/​github.com/​xuri/​excelize/​v2@​v2.11.0 ⏵ v2.11.1-0.20261029001137-c5fd73bde8f696100 +75100100100
Updatednpm/​ai@​6.0.33 ⏵ 6.0.32098 +110010099100
Updatedgolang/​golang.org/​x/​sync@​v0.22.0 ⏵ v0.24.099 +1100100100100
Updatedgolang/​go.opentelemetry.io/​otel/​trace@​v1.44.0 ⏵ v1.45.0100 +1100100100100
Updatedgolang/​golang.org/​x/​term@​v0.44.0 ⏵ v0.47.0100 +1100100100100

View full report

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Gavel summary

Source Pass Fail Skip Duration
lint: oxlint 0 1 0 175ms
lint: betterleaks 0 0 1 -
lint: golangci-lint 1 0 0 2m17s
lint: react-doctor 1 0 0 5.9s
lint: tsc 2 0 0 5.1s

Totals: 4 passed · 1 failed · 1 skipped · 2m28s

Failing linters

oxlint — 3 violation(s)

  • /home/runner/work/clicky/clicky/examples/enitity/webapp/src/api.ts:53 — Empty fallbacks in spreads are unnecessary (oxlint)
  • /home/runner/work/clicky/clicky/examples/enitity/webapp/src/api.ts:133 — Empty fallbacks in spreads are unnecessary (oxlint)
  • /home/runner/work/clicky/clicky/examples/enitity/webapp/src/LinkExamplesPage.tsx:217 — Empty fallbacks in spreads are unnecessary (oxlint)

View full results

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Gavel summary

Source Pass Fail Skip Duration
aichat 24 0 0 1ms
api 342 0 0 18ms
cache 28 0 0 120ms
celfilter 14 0 9 19ms
clicky 129 0 0 1m7s
clirender 18 0 0 462.473µs
enitity 1 0 0 5.9s
entity 171 0 0 119ms
entitydemo 1 0 0 1ms
excel 37 0 0 118ms
exec 153 0 1 13.2s
extensions 1 0 0 90.413µs
filter 10 0 3 1ms
flags 41 0 0 1ms
formatters 85 0 0 5ms
github.com/flanksource/clicky 28 0 0 3.0s
github.com/flanksource/clicky/api 258 0 0 170ms
github.com/flanksource/clicky/api/tailwind 434 0 0 -
github.com/flanksource/clicky/api/wasmtest 1 0 0 280ms
github.com/flanksource/clicky/cmd/clicky 4 0 0 -
github.com/flanksource/clicky/docs 19 0 0 100ms
github.com/flanksource/clicky/entity 153 0 0 -
github.com/flanksource/clicky/examples/enitity/internal/entitydemo 7 0 0 -
github.com/flanksource/clicky/exec 3 0 0 370ms
github.com/flanksource/clicky/flags 53 0 0 10ms
github.com/flanksource/clicky/formatters 77 0 1 20ms
github.com/flanksource/clicky/formatters/http 38 0 0 -
github.com/flanksource/clicky/formatters/tests 201 0 1 10ms
github.com/flanksource/clicky/internal/gumchoose 2 0 0 -
github.com/flanksource/clicky/lint 13 0 0 -
github.com/flanksource/clicky/markdown 10 0 0 60ms
github.com/flanksource/clicky/mcp 102 0 0 2.6s
github.com/flanksource/clicky/middleware 31 0 0 -
github.com/flanksource/clicky/prompt 15 0 0 -
github.com/flanksource/clicky/route 12 0 0 -
github.com/flanksource/clicky/rpc 378 0 1 90ms
github.com/flanksource/clicky/rpc/http 8 0 0 10ms
github.com/flanksource/clicky/task 169 0 0 18.8s
github.com/flanksource/clicky/valkey 1 0 0 320ms
gomplatefilter 2 0 0 2ms
http 5 0 0 202.817µs
lint 16 0 0 8.1s
markdown 9 0 0 45ms
mcp 4 0 0 2ms
metrics 17 0 0 3.0s
middleware 38 0 0 9ms
process 46 0 0 1.8s
rpc 59 0 0 1.9s
schemaform 61 0 0 1.7s
sse 74 0 0 1.7s
task 108 0 0 7.7s
tests 11 0 47 2ms
text 78 0 0 304ms
urlfetch 4 0 0 1ms
valkey 46 0 0 314ms

Totals: 3650 passed · 0 failed · 63 skipped · 2m19s

View full results

@moshloop
moshloop merged commit 5f5375e into main Nov 1, 2026
16 of 18 checks passed
@moshloop
moshloop deleted the chore/oipa-sync-20261022 branch November 1, 2026 10:22
@flankbot

flankbot commented Nov 1, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 1.21.90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants