Repository navigation
chore: remove task-ui bundle, bump deps - #231
Conversation
Spreadsheet column flags can now pick a worksheet by name (Sheet!Column, with quoted names for spaces) or by one-based position (#2!Column), instead of always reading the first sheet. Pointer-to-bool fields now distinguish omitted, false and true across CLI and request inputs. BREAKING CHANGE: SpreadsheetReader now takes a SpreadsheetReadOptions argument, so custom readers passed to SetSpreadsheetReader must update their signature.
…d terminal output Literal text was emitted unescaped in HTML and Markdown, and list, link, and code output broke on special characters. Text, attributes, link destinations, and code fences are now escaped or sized to their content, and lists share one renderer across formats. Raw HTML is converted to plain text for terminal output. BREAKING CHANGE: TextTable.HTML() now renders static markup unless Interactive is set, and expandable row details are no longer wrapped in Alpine.js templates.
Drop the explicit Metrics disable option so the task queue uses the default metrics setting and reports metrics again. This adds metric emission overhead and new series to dashboards. BREAKING CHANGE: the task queue now emits metrics by default, which may increase metric cardinality and resource usage.
Bump flanksource captain, commons, gomplate, commons-db and is-healthy to newer releases, and move the gavel CI action to v0.0.64. Several modules are also downgraded: charmbracelet/x/conpty to v0.1.0, glebarez/go-sqlite to v1.21.2, and go-test/deep to v1.0.3. New indirect deps include sqlglot-go, glebarez/sqlite, gorm sqlserver and pb33f/ordered-map. Unused indirect modules such as lmittmann/tint, shirou/gopsutil/v3 and the vadimi NTLM packages are removed. The webapp moves @flanksource/clicky-ui to 0.3.54, and format.go gains Avatar and KeyMap helpers. No public API is removed, so no breaking change is expected, but the downgrades should be verified against the affected code paths.
…s snapshot Prompts raised inside a running task are now labeled with that task's id, so the task snapshot can list the questions it is blocked on. A nested task overwrites the label, so a prompt belongs to the innermost running task. Adds an optional TaskSnapshot.Prompts field (json prompts,omitempty); the change is additive and does not alter existing behavior.
…of polling A member that could not take its group's permit was re-enqueued with a 50ms delay. The queue only looks at its head, which is always the group's oldest waiting member, so while it sat out the delay no worker could dequeue anything: a bounded group drained about one member per 25ms whatever its concurrency (2,000 members at concurrency 4 took ~55s). Such a member now parks in the group's admission line, out of the queue, and is handed back when a permit is released, the member ahead of it is admitted or retires, or it is cancelled or its context ends. Claude-Session-Id: 45e3588e-f94a-44ba-8624-b1eb77edf56c
Replace the semaphore with a worker limit: workers numbered at or above the current maximum take no tasks, so a lowered SetMaxConcurrent now takes effect. Workers are started on demand when the maximum is raised, and foregroundWorkersActive reads tm.workers under mu because the slice can grow. Also registers stream metrics routes under the tasks prefix.
…d append frames Panels need one query per tick across many series. This adds SeriesSource, which answers many ids in one call, and Sources, which routes each id to a source by its prefix. GET metrics/stream sends a snapshot and then append frames over SSE, so one subscription serves a whole page of panels. Existing endpoints are not changed.
… workflows The task/ui Preact frontend and its committed dist/taskui.js were go:embed'd and kept in sync by the dist and release workflows. Remove the package, both bundle-rebuild jobs, and the uber-demo task-ui command, since the embedded bundle was the only consumer. Also bumps example module dependencies and lockfiles, and switches the entity demo to ComposeSpecLayers. BREAKING CHANGE: the task/ui taskui package (Handler, bundleJS) is removed and the uber-demo task-ui command no longer exists.
…ui bundle Bumps Go modules (golang.org/x/*, otel, commons-db, captain, gomplate-adjacent indirects) and the builder image to golang:1.27.3-alpine. Playwright now comes from github.com/mxschmitt/playwright-go, and glebarez/sqlite is replaced with clarkmcc/gorm-sqlite to avoid a duplicate modernc sqlite driver registration at init. Process environment reads now skip zombie and exiting processes and tolerate processes that exit mid-read, and Snapshot.Children is added. BREAKING CHANGE: task.JSONHandler is removed, and the task-ui frontend bundle is no longer built by make or cleaned up, and its go:embed un-ignore rules are dropped from .gitignore.
|
Caution Review failedThe pull request is closed. WalkthroughThe PR removes the embedded task UI, changes task scheduling and prompt snapshots, adds a metrics series streaming API, and updates Markdown rendering, spreadsheet selection, process snapshots, the entity demo profile, build configuration, and dependencies. ChangesTask UI removal
Task execution and prompts
Metrics series streaming
Markdown and rich-value rendering
Flags and spreadsheet selectors
Process snapshots
Entity demo profile
Build and dependency updates
Sequence Diagram(s)sequenceDiagram
participant Client
participant MetricsRoute
participant SeriesSource
Client->>MetricsRoute: Request metrics stream
MetricsRoute->>SeriesSource: Query requested series
SeriesSource-->>MetricsRoute: Return series and points
MetricsRoute-->>Client: Send snapshot
MetricsRoute->>SeriesSource: Query on each interval
SeriesSource-->>MetricsRoute: Return updated series
MetricsRoute-->>Client: Send appended points or removed IDs
Possibly related PRs
Suggested reviewers: Change: Other Merge Risk:
|
Gavel summary
Totals: 4 passed · 1 failed · 1 skipped · 2m28s Failing lintersoxlint — 3 violation(s)
|
Gavel summary
Totals: 3650 passed · 0 failed · 63 skipped · 2m19s |
|
🎉 This PR is included in version 1.21.90 |
What
Why
Notes
Summary by CodeRabbit