Repository navigation
fix(deps): pin clicky to v1.21.95 - #165
Conversation
Claude-Session-Id: 754971f0-98ba-4fb1-bae2-399104179627
|
No actionable comments were generated in the recent review. WalkthroughThe approval broker changes how it handles errors and caller cancellation. New tests cover cancellation before and during polling, and cancellation after a request is resolved. The Clicky requirement in ChangesApproval cancellation handling
Clicky dependency update
Possibly related PRs
Suggested reviewers: Change: Other Merge Risk:
|
Gavel summary
Totals: 0 passed · 0 failed · 0 skipped · - |
Gavel summary
Totals: 7478 passed · 0 failed · 16 skipped · 11m22s |
Abandoned approvals were previously marked in each early-return path, so cancellation and hook or notify failures could leave the durable row unresolved or skip releasing the run. The deferred handler now abandons the pending request once on any error and returns the raw error from each call site. Adds Ginkgo specs covering cancellation before and during a poll, and preservation of a decision resolved concurrently. Gavel-Issue-Id: 1c9a18e7-cae4-45fb-a0dc-17aef6a0f477 Claude-Session-Id: 01a1e31b-5120-7001-b6f7-30a65b11e0a9
What
clickytov1.21.95ingo.modandgo.sumWhy
Summary by CodeRabbit