feat: add default journal store name constant - #3
Open
davidfrigolet wants to merge 1 commit into
Open
davidfrigolet wants to merge 1 commit into
davidfrigolet wants to merge 1 commit into
Conversation
Adds DEFAULT_JOURNAL_STORE_NAME to CommunityPersistenceConstants, next to the existing audit/lock/marker store defaults. Each community audit store (SQL, DynamoDB, MongoDB) previously hardcoded its own copy of the "flamingockJournalEvents" literal; centralizing it here removes that triplication and gives the journal store the same single source of truth the other default names already have.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
DEFAULT_JOURNAL_STORE_NAME("flamingockJournalEvents") toCommunityPersistenceConstants, alongside the existingDEFAULT_AUDIT_STORE_NAME/DEFAULT_LOCK_STORE_NAME/DEFAULT_MARKER_STORE_NAME.Each community audit store in
flamingock-java(SQL, DynamoDB, MongoDB sync) currently hardcodes its own copy of the"flamingockJournalEvents"string in a separate local constants class, because this class couldn't be extended for it before now. Adding the constant here lets all three point at one source of truth instead of three independently-maintained literals.This is part 1 of 3 in centralizing Journal Event persistence (this, a SQL dialect-helper extraction, then
flamingock-javawiring). See companion PRs:Test plan
./gradlew test— passes./gradlew spotlessCheck— license headers passgeneralUtilVersioninflamingock-java's companion PR