Claude/great hawking al4kaa - #3
Merged
Merged
Conversation
Flag deletes never took effect in a running client SDK: both storage managers only spread-merged incoming sets, and the SSE stream carried partial updates. This consumes the full-set sync the backends now provide on every sync path: - memory and localStorage managers gain replace(), which drops flags absent from the incoming set — the only way deletes can propagate. A new internal UPDATE_RECEIVED_FULL event routes full sets to it; UPDATE_RECEIVED stays merge-based for legacy partial updates. - stream-manager listens for the named "flags" SSE event (full evaluated value map, replace semantics) and ignores legacy partial messages once full-set support is observed, so a change is not applied twice. - stream-manager consumes the server's 25s "heartbeat" events to drive a staleness watchdog that restarts half-dead connections no error event would ever surface. - On reconnect, the stream manager refetches /sdk/flags and replaces the store, recovering updates emitted while disconnected (there is no server-side replay). - ws-manager and poll-manager switch to UPDATE_RECEIVED_FULL: Sunrise always pushes the entire value map and polling always fetches it, so both were already full sets being incorrectly merged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XHpkNV7Bi4SHg4cjon8HqP
kill() only closed the socket when readyState was OPEN and never cleared a pending reconnect timer, so a kill landing during the reconnect window (or mid-handshake) let the SDK reopen a connection after shutdown. kill() now clears the reconnect timer, guards future reconnects with a killed flag, and closes the socket when OPEN or CONNECTING. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XHpkNV7Bi4SHg4cjon8HqP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.