Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

test/multi-source-spellings-variable - #61

Closed
fivetran-catfritz wants to merge 1 commit into
mainfrom
test/multi-source-spellings-variable
Closed

test/multi-source-spellings-variable#61
fivetran-catfritz wants to merge 1 commit into
mainfrom
test/multi-source-spellings-variable

Conversation

@fivetran-catfritz

@fivetran-catfritz fivetran-catfritz commented Jul 31, 2025

Copy link
Copy Markdown
Contributor

PR Overview

Package version introduced in this PR:

This PR addresses the following Issue/Feature(s):

  • GA-1000753
  • Solution 2

Summary of changes:

Solution 2 – Use an Externally Set Variable Flag

This approach handles alternate spellings by:

  • Introducing a variable to determine which source spelling to use
  • The variable must be set externally (e.g., by the user or in quickstart)

Pros:

  • Lower long-term maintenance
  • More scalable across packages
  • The same variable can be reused in multiple packages with no package-specific logic

Cons:

  • Requires a quickstart update to set the variable, so it’s not usable immediately

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention

Changelog

  • Draft changelog for PR
  • Final changelog for release review

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant