Skip to content

make useSandbox tolerate undefined props#536

Merged
czerwiukk merged 1 commit into
mainfrom
make-use-sandbox-not-raise-type-error
May 13, 2026
Merged

make useSandbox tolerate undefined props#536
czerwiukk merged 1 commit into
mainfrom
make-use-sandbox-not-raise-type-error

Conversation

@czerwiukk
Copy link
Copy Markdown
Member

@czerwiukk czerwiukk commented May 13, 2026 •
edited
Loading

useSandbox() now raises a TypeError, we can avoid that and raise the MissingSandboxApiUrlError later

@czerwiukk czerwiukk requested a review from Magmusacy May 13, 2026 10:56
@czerwiukk czerwiukk self-assigned this May 13, 2026
@czerwiukk czerwiukk enabled auto-merge (squash) May 13, 2026 10:57
Magmusacy
Magmusacy approved these changes May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Magmusacy Magmusacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potat

@czerwiukk czerwiukk merged commit b5ba6b0 into main May 13, 2026
2 checks passed
@czerwiukk czerwiukk deleted the make-use-sandbox-not-raise-type-error branch May 13, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Magmusacy Magmusacy Magmusacy approved these changes

Assignees

@czerwiukk czerwiukk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@czerwiukk @Magmusacy