Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancel Ollama downloads and uninstall models from Settings
Frontend for #57. Needs the backend from fireform-core/FireForm#754.
Why
What changed
AbortControllerlives in the global state and its signal goes tofetch. A Cancel button in the floating panel and next to the model being downloaded in the providers window is the only thing that aborts it; changing page does not. A cancelled download shows a neutral message, not an error. The model is not marked as installed or selected, and the catalog is reloaded.DELETE /api/v1/system/llm/modelsis sent withprovider: "ollama". On success the catalog is reloaded and the pinned models are updated. If the deleted model was the selected one, the selector moves to a valid selection and the user is told.lib/api.ts,store/index.ts,App.tsx,ProviderConfigModal.tsxandConfirmDialog.tsx.Notes
Testing
npm run typecheckandnpm run buildpass.npm run lint: 0 errors, 33 warnings (same count as before).Closes #57