Repository navigation
fix(pptx): preserve OLE previews and select supported markup branches - #207
Open
crown-sports wants to merge 2 commits into
Open
crown-sports wants to merge 2 commits into
crown-sports wants to merge 2 commits into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply to a comment to ask cubic a question or push back. It learns from your replies.
Click Fix with cubic on a comment, or reply @cubic-dev-ai fix this, and cubic writes the fix.
View guided diff | Re-trigger cubic
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PPTX embedded objects can expose their OLE compound payload as an image while silently losing the preview that the slide actually displays. Prefer the object's preview image, retain the original OLE payload in
Document.assets, and preserve the existing payload fallback when no usable preview exists.Graphic-frame searches now traverse only the selected
mc:AlternateContentbranch, including nested alternatives and later sibling content. This prevents rejected tables or OLE objects from hiding the supported representation. Shape-level OLE wrappers use the same parsing path, and the supported namespace set includes the chart and diagram formats this reader already handles.Fixes #182. Thanks to the report and follow-up analysis there for identifying both the lost preview and the payload-retention requirement.
Validation
main(e7178e099b6bf9171e2c52b832cbdb4134b69112), these tests produce 12 failures / 1 pass; with this change, 13 pass.cargo test --locked: 311 passed, 1 ignored (the existing optional local-samples test).cargo fmt --all --check: passed.cargo clippy --workspace --all-targets --all-features -- -D warnings: passed.AI assistance was used for implementation, testing, and independent review. Node/Python/Wasm runtime tests were not run locally; their crates are covered by the workspace Clippy check above.