Repository navigation
fix(auth): update token expiration buffer to 5 minutes - #10535
Open
macastelaz wants to merge 2 commits into
Open
macastelaz wants to merge 2 commits into
macastelaz wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 0c886e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the on-demand ID token expiration buffer (Buffer.TOKEN_REFRESH) from 30 seconds to 5 minutes to match the proactive refresh offset, updating relevant tests and mocks accordingly. Feedback highlights a critical issue in phone.test.ts where variable shadowing leads to a vacuous assertion, meaning the test passes without actually verifying the token update.
…se expiresIn in account_info.test.ts
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
Buffer.TOKEN_REFRESHinpackages/auth/src/core/user/token_manager.tsfrom30_000(30 seconds) to5 * 60 * 1000(5 minutes) so that on-demandStsTokenManager.isExpiredchecks (user.getIdToken()) match:User.getIdToken()behavior ("Returns the current token if it has not expired or if it will not expire in the next five minutes").Duration.OFFSET(5 * 1000 * 60) used byProactiveRefresh(proactive_refresh.ts).Also updates unit test fixtures that previously used 100-second token lifetimes (
100_000ms) to account for the 5-minute expiration buffer while preserving existing test coverage.Testing
yarn --cwd packages/auth test:node:unit(714 passing)yarn --cwd packages/auth test:browser:unit(1,082 passing)yarn format&yarn --cwd packages/auth lint