feat(fcm): add retry config client option support#760
Closed
aminpaydar wants to merge 1 commit intofirebase:masterfrom
Closed
feat(fcm): add retry config client option support#760aminpaydar wants to merge 1 commit intofirebase:masterfrom
aminpaydar wants to merge 1 commit intofirebase:masterfrom
Conversation
Allow callers to pass retry policy through option.ClientOption so Messaging can honor custom retry behavior from NewApp options. When no retry option is supplied the default retry config is still applied.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to configure HTTP retry behavior for the Firebase Admin SDK by adding a WithRetryConfig client option. Key changes include updating NewHTTPClient to extract retry configurations from options, implementing a CloneHTTPClient function to perform deep copies of client settings, and refactoring the messaging service to utilize these new capabilities while ensuring service-specific headers do not affect the base configuration. I have no feedback to provide as the review comments were explanatory or provided non-actionable instructions for future maintenance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow callers to pass retry policy through option.ClientOption so Messaging can honor custom retry behavior from NewApp options. When no retry option is supplied the default retry config is still applied.