Skip to content

Configure "delete account" button behavior#1339

Open
megastep wants to merge 3 commits intofirebase:mainfrom
megastep:configure-delete-account
Open

Configure "delete account" button behavior#1339
megastep wants to merge 3 commits intofirebase:mainfrom
megastep:configure-delete-account

Conversation

@megastep
Copy link
Copy Markdown
Contributor

@megastep megastep commented May 4, 2026

This makes the "Delete Account" button in the SignedInView configurable, for cases when the application needs more advanced account deletion configuration:

  • Existing behavior (default) with confirmation dialog;
  • Button disabled; or
  • Custom action on clicking

This also includes the changes from my previous PR #1338 to disable the MFA button if that is turned off in the project's configuration.

Also fixes some missing localized strings in the dialog, even though the strings were already localized.

megastep and others added 3 commits May 3, 2026 23:58
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the ability to customize the account deletion button behavior in SignedInView via the AuthConfiguration. It adds a new DeleteAccountButtonAction enum allowing the button to be shown with a default confirmation sheet, hidden entirely, or linked to a custom action. Additionally, it includes UI updates to conditionally display the MFA management and delete account buttons, localizes strings in the deletion confirmation sheet, and adds corresponding unit tests and documentation. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant