[TRNF-8322] Feat(v2): Support the onboarding type and data create shape - #31
Merged
Merged
Conversation
The public API now requires a `type` on entity onboarding creation (`account_holder` or `settlement_recipient`) and takes the company information, legal representatives, transactional profile and shareholders nested under `data` instead of at the top level. Expose the `type` the API returns on the onboarding object, and move the docs and specs to the current request shape.
tlarrain
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexto
El API público v2 cambió el contrato de creación de onboardings de entities: ahora
exige un
type(account_holderosettlement_recipient) y recibe el payloadanidado bajo
data, en vez de las estructuras al nivel superior. El SDK quedódocumentando y testeando la forma antigua, que hoy responde 422.
¿Qué hay de nuevo?
Fintoc::V2::Onboardingexponetype(el API ya lo devuelve en show e index)createusatype:+data:, con valores MX reales y los enums vigentesonboarding.typeTests
Onboardingcubrentypeen la forma completa y en la livianaOnboardingsManagerarma el body decreatecontype+dataSafety Checks
Consideraciones
createya soportaba lanueva forma sin cambios: lo que estaba desactualizado eran las specs y el README.
completa lo que faltaba del schema (
typeydata).Rollback
Seguro. Es un cambio aditivo (un
attr_readernuevo) más documentación y specs;revertir el commit deja el SDK como estaba.