Repository navigation
Pin morphir-typescript and morphir-python to the complete Morphir SDK - #847
Merged
Merged
Conversation
Move ecosystem/morphir-typescript from 692557c to a5e3be0 (finos/morphir-typescript#28) and ecosystem/morphir-python from 2047614 to dc0b317 (finos/morphir-python#25). Both add the remaining modules of the Morphir.SDK package specification: LocalDate, LocalTime, Instant, UUID, Regex, Aggregate, Rule, Key, StatefulApp and ResultList.
✅ Deploy Preview for angry-raman-7c44f6 canceled.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves two submodules to the merges that complete the Morphir SDK runtimes:
ecosystem/morphir-typescript692557ca5e3be0ecosystem/morphir-python2047614dc0b317Both add the remaining modules of the
Morphir.SDKpackage specification: LocalDate, LocalTime, Instant, UUID, Regex, Aggregate, Rule, Key, StatefulApp and ResultList. Each repository now has a test that checks every value of all 22 specified modules.Each new pin is the direct child of the old one, so no other change comes with it. Only the two gitlinks change.
Test plan