Repository navigation
docs(ion): fix the match spelling and define the collapsed record - #1133
Open
DamianReeves wants to merge 1 commit into
Open
DamianReeves wants to merge 1 commit into
DamianReeves wants to merge 1 commit into
Conversation
The draft's match row wrote `[pattern body]`, which is not legal Ion because list items need commas. The reference writer emits `[_, 1,]`. The draft says a reader accepts a collapsed `morphir::` record but never named its members. Define the `dependencies` and `modules` lists that the Rust reader expands. The knowledge base still said the v4 reader refuses a record. CLI 0.4.0-beta.12 reads v3 library and v4 library, specs and application records to JSON byte-identical to the equivalent datagrams. Found while planning the Ion reader for finos/morphir-dotnet.
✅ Deploy Preview for angry-raman-7c44f6 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two corrections to the Ion draft, and one stale knowledge base note. All three came up while planning an Ion reader for finos/morphir-dotnet. Refs #946.
Changes
matchrow. The table wrote(match scrutinee [pattern body] [pattern body]), which is not legal Ion because list items need commas. It now writes[pattern, body]. This matches the draft's canonical text rules and what the writer already emits.dependenciesandmoduleslists that the Rust reader expands, with an example.ion-ir-format.mdsaid the v4 reader refuses a record. That is no longer true, so I removed the note and updated the text and the log.No reader or writer behavior changes. Because the draft now documents what the codec already does, I did not update discussions 938 and 942. Say if you want them updated too.
Evidence
I ran the
morphirv0.4.0-beta.12 release (aarch64-pc-windows-msvc, SHA-256 checked) withir migrate:matchbody[,_,,1,,]on separate linesSeparately,
Eleven19.IonDotnetrejects[_ ()]and accepts[_, ()].Not in this PR
morphir-vvgi.8("Ion v4: read the collapsed morphir:: record") is still open and looks ready to close.ion_linked_metadata.rs, for the linked-metadata draft.0.1.0-draft.1v4 records may want their own test in finos/morphir-rust.I did not run
mise run checklocally. This PR relies on CI for those checks.🤖 Generated with Claude Code