Repository navigation
feat(extensions): resolve the Python extension from finos/morphir-python - #1104
Merged
Merged
Conversation
…s it A [bundles.*] pin can now name its releasing repository as `owner/name`, as [executables.*] pins already do. A pin without one still comes from finos/morphir-rust, so the existing pins download the same assets. A repository that is empty or not of the form owner/name is refused, for bundle and executable pins alike. The guest is still checked against the pinned sha256. finos/morphir-python now owns the Python extension. The python pin names finos/morphir-rust explicitly, because extension/python/v0.4.0 is released there, and says to move to finos/morphir-python when it publishes extension/python/v0.4.1.
The Python compiler crate, morphir-python-binding, its extension guide and new extension/python/v* bundles now live in finos/morphir-python. Bundles up to extension/python/v0.4.0 stay in the finos/morphir-rust releases. Update the installation guide, the release-manager skill, the ecosystem guides and the host compatibility test comment to say so, and note that a morphir-python release on PyPI that includes the compiler gives the same compiler as a Python API and command.
✅ Deploy Preview for angry-raman-7c44f6 canceled.
|
finos/morphir-python published extension/python/v0.4.1 (guest sha256 a04722e1, built from 0d7e2eb). Fetch it from that repository. The python_extension and host_compatibility python tests pass against it.
DamianReeves
marked this pull request as ready for review
October 27, 2026 23:32
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
morphir-pythonMEP extension (cratemorphir-python-binding, bundle tagsextension/python/v*) moved from finos/morphir-rust to finos/morphir-python (finos/morphir-python#41). Its removal from morphir-rust is in finos/morphir-rust#314. This PR prepares the ecosystem references (OpenSpecmigrate-python-binding, beadmorphir-ukvn.1.6.7).tools/fetch-published-bundles.ts: a[bundles.*]pin can name therepositorythat owns it (owner/name). Pins without one still come from finos/morphir-rust, so the downloads are unchanged, and the guest sha256 check is unchanged. Malformed repositories are refused for bundle and executable pins. There are 6 new tests..config/published-extension-bundles.toml:[bundles.python]stays on the publishedextension/python/v0.4.0and now namesfinos/morphir-rustexplicitly. A comment says when to move it.host_compatibility.rsnow point the Python extension's source and future releases at finos/morphir-python. They say that the historical bundles stay in morphir-rust releases.Verification
mise run tools:typecheckandbun test tools: 162 pass.python3 -B -m unittest discover -s tests/ci: 55 OK.mise run checkpasses.MORPHIR_PYTHON_BUNDLE=<bundle built in finos/morphir-python at 2b96642, v0.4.1> cargo test --release -p morphir --test python_extension -- --ignored: 1 passed. An isolated install selects the bundle built in finos/morphir-python and round-trips offline, with no Python crate in morphir-rust.host_compatibilitycases for python, avro, openapi and rust pass against the current pins.Before merge (draft)
extension/python/v0.4.1.[bundles.python]torepository = "finos/morphir-python",tag = "extension/python/v0.4.1",artifact = "morphir-python-binding-0.4.1", and the sha256 of the published guest, computed from the release asset. The release publishes the bundle CI built from the tagged commit; the 2026-10-27 qualification run built a guest with sha256a04722e1…. A local macOS build differs, so do not use a local digest. With those values,host_compatibility(python) andpython_extensionpass locally.