Repository navigation
feat(cli): add bounded Python Extism adapter - #266
Merged
Merged
Conversation
Use an explicit verified bundle pin and the shared restricted host for legacy MEP0.1 IR3/4 operations. Require advertised multi-document support; Python0.4.1 receives no digest exception. Tested-on: macOS 26.6.2 arm64; mise run test:cli-native-prerequisites, mise run test:cli-extism-python with local corrected candidate, mise run lint, mise run validate
Keep the existing unavailable-runtime error when no binding is selected. Explicit Extism pins retain their structured unsupported-target result. Record published Python0.4.2 qualification and the matching PyPI API pair. Tested-on: macOS 26.6.2 arm64; npm test --prefix apps/morphir -- wasm, npm test --prefix apps/morphir -- wasm-gc, mise run test:cli-extism-python, mise run lint, mise run validate
DamianReeves
marked this pull request as ready for review
October 28, 2026 05:58
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a7c98080b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Check the cancellation file through input preparation and the final publication rename, preserving exit130 for late cancellation. Create the qualification receipt directory when bundle inputs live elsewhere. Tested-on: macOS 26.6.2 arm64; 53 native CLI units, 7 native/JS Extism checks, full published-bundle qualification with the receipt directory absent, mise run lint, mise run validate
Use import syntax accepted by MoonBit 0.10.16. Tested-on: macOS 26.6.2 arm64; pinned script unit tests, JSON help, syntax and old-bundle refusal; mise run lint, mise run lint:moonbit, mise run validate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an explicit
extism-wasmbinding for the Python extension's legacy MEP 0.1 describe, compile and generate operations. Compile and generate require IR 3 or IR 4 and plain JSON. A multi-module request requiresfrontend.multiDocument=true; Python 0.4.1 is refused for that use without a digest exception.The adapter reuses the shared Rust container and session checks with the bounded policy landed in morphir-rust#315 and morphir#1108. Pins cover the host, Node runtime, helper closure, descriptor and WASM. The helper runs immutable copies with denied guest network/environment/preopens, bounded resources, cancellation and observed process cleanup before transactional output publication.
Review the design, behavior contract and CLI guide. All 17 OpenSpec tasks are complete. Acceptance uses the published Python 0.4.2 bundle and independently installed PyPI packages
morphir==0.1.0,morphir-python==0.1.0andmorphir-python-native==0.1.1, whose compiler reports 0.4.2. Both verified review findings are fixed in4951183d34fddd7c8f04e0d3b3622fa1a5367c1e: late cancellation prevents the final publication rename with exit 130, and qualification creates its missing receipt directory. All 53 native CLI units and seven native/JS Extism checks pass. Full published-bundle acceptance also passes with the receipt directory absent and inputs held elsewhere. The full published-bundle receipt passes on final candidate4951183d34fddd7c8f04e0d3b3622fa1a5367c1eusing the repository-pinned runner. Pinned help/syntax/refusal and receipt-validator tests pass. Aggregatemise run checkpasses; CI is running on the final head. Full receipt evidence is retained in beadmorphir-ukvn.5.98.4.Validation on macOS arm64:
Only macOS arm64 receives candidate evidence here. Linux GNU and macOS x86_64 remain unqualified; Windows, musl, browser and MoonBit wasm/wasm-gc execution remain unsupported. No CI workflow or scarce-runner job is added.
Tracking:
morphir-ukvn.5.98, related Python documentation intentmorphir-ukvn.9/add-documentation-site. Corrected Python release: morphir-python#50.Tested-on: macOS 26.6.2 arm64; mise run test:cli-native-prerequisites, mise run test:cli-extism-python with published bundle/API, npm test --prefix apps/morphir -- wasm, npm test --prefix apps/morphir -- wasm-gc, mise run lint, mise run validate