Repository navigation
docs: state the torch 2.14 floor where the compile doors still said 2.13 - #104
Merged
Merged
Conversation
The floor is torch>=2.14 since c438709, the first release with the Inductor eye-write miscompile fixed, but the refusal a fullgraph compile prints still said Inductor "(torch 2.13) silently miscompiles". The doors stay; their reason now says why: compiling wavebit buys no speed, and Inductor has miscompiled it before (2.13, fixed in 2.14). - EAGER_REASON and the door docstring: past tense for the defect, the reason the doors stay. - asarray docstring: re-measured on 2.14.1 (negative strides still raise; requires_grad and the graph are still kept). - torch-compile.md, torch-upstream-defects.md, backends-v1.md: the floor is 2.14; torch.linalg.solve's forward-rule defect holds through 2.14; the defect-1 canary's current name. Historical measurements on 2.13.0 are left as written. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The torch floor has been
torch>=2.14since c438709. That is the first release with the Inductor eye-write miscompile fixed (pytorch/pytorch#182012). The refusal thattorch.compile(fullgraph=True)prints still said Inductor "(torch 2.13) silently miscompiles", as if the defect were current.The doors stay. Compiling wavebit buys no speed: the solve is about 98% LAPACK, which Inductor forwards as is. The doors also hold the by-name refusals of
fullgraph,torch.exportandtorch.jit.trace. This PR only corrects the text.Changes
EAGER_REASON: now gives the current reason (no speed gain, plus a past miscompile on 2.13 that 2.14 fixed).asarraydocstring: re-measured on 2.14.1. Arrays with negative strides still raise, andrequires_gradand the graph are still kept.torch-compile.md:torch.linalg.solveforward-rule defect is now dated "2.13 and 2.14" (it is wrong on 2.14.1 too, pertorch-upstream-defects.md).torch-upstream-defects.md: the floor is now 2.14, and the defect-1 canary is listed under its current name.backends-v1.md: the floor is now 2.14, with the reason.Historical measurements on 2.13.0 are left as written.
Checks
tests/api/test_torch_compile.pyandtests/api/test_docs_contract.py: 186 passed on torch 2.14.1.🤖 Generated with Claude Code