SK: editions 2018-2026 - #326
Merged
Merged
Conversation
ivorbosloper
marked this pull request as ready for review
September 24, 2026 20:29
ivorbosloper
force-pushed
the
sk-editions
branch
from
September 25, 2026 10:33
a968a69 to
5306a2a
Compare
m-mohr
reviewed
Sep 25, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Restore the sequential crop:code mapping in fiboa_cli/datasets/sk.py.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Extends Slovakia dataset support to campaign-year variants from 2018–2026.
Changes:
- Adds yearly download sources and schema normalization.
- Expands crop mappings and conversion coverage.
- Documents the expanded editions.
The existing sequential crop:code mapping should be restored in the Slovakia converter.
| File | Summary |
|---|---|
tests/test_convert.py |
Adds 2018 conversion coverage. |
tests/data-files/convert/sk/sk.csv |
Updates Slovak crop mappings. |
fiboa_cli/datasets/sk.py |
Adds yearly variants and schema handling. |
CHANGELOG.md |
Documents expanded SK editions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
m-mohr
force-pushed
the
sk-editions
branch
2 times, most recently
from
September 25, 2026 12:21
5690610 to
0af2e20
Compare
m-mohr
added this pull request to stack #334
September 25, 2026 12:21
Collaborator
Author
|
Seems ready now |
Read the per-campaign "Hranice užívania" datasets on data.slovensko.sk instead of one rolling download, rename the 2018/PLODINA_NA columns to the current schema, and normalise no-break spaces in crop names so the grassland names match the crop table. Ports f3ce959 from #214. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rgette) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
m-mohr
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SK now reads the per-campaign datasets as year variants 2018-2026, mimics f3ce959 from #214.