Actually test on Python 3.11, not just 3.14 - #324
Merged
Merged
Conversation
m-mohr
requested review from
ivorbosloper and
saidy-moregeo
and
a lite review from Copilot
September 24, 2026 13:24
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Updates CI to genuinely test Python 3.11 and 3.14 using dedicated Pixi environments, with compatible test fixtures.
Changes:
- Adds Python-version-specific Pixi environments.
- Runs CI through the matching environments with version checks.
- Replaces
TemporaryDirectory(delete=False)withmkdtemp().
| File | Description |
|---|---|
tests/conftest.py |
Makes temporary-folder setup Python 3.11 compatible. |
pyproject.toml |
Defines Python 3.11 and 3.14 Pixi environments. |
.github/workflows/checks.yml |
Runs CI tasks using the corresponding Pixi environment. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems we were never actually testing on Python 3.11, but on 3.14.
See also vecorel/cli#54