Skip to content

Confirm suspicious power snapshots before publish - #37

Closed
ffrog8 wants to merge 4 commits into
masterfrom
feature/power-snapshot-confirm
Closed

ffrog8 wants to merge 4 commits into
masterfrom
feature/power-snapshot-confirm

Conversation

@ffrog8

@ffrog8 ffrog8 commented Apr 16, 2026

Copy link
Copy Markdown
Owner

Summary:

  • confirm suspicious power tuples with up to three full reads before publishing ESS/Grid/Solar/Load
  • skip power-entity publishes for that cycle when all three samples remain invalid or suspicious, and publish compact retained power snapshot diagnostics
  • expose RS485 transaction quiet/wait/attempt counts for the final power-tuple decision and reduce the pre-TX quiet gap default from 20ms to 10ms

Verification:

  • host tests: passed via ./scripts/test_host_docker.sh
  • firmware build: passed via Alpha2MQTT/build.sh in arduino-cli-build

ffrog8 commented Apr 16, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e3513f7d32

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Alpha2MQTT/src/main.cpp Resolved

ffrog8 commented Apr 16, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7d49e9df1c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Alpha2MQTT/src/main.cpp Resolved

ffrog8 commented Apr 16, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 74ef49bb5f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Alpha2MQTT/src/main.cpp Resolved

ffrog8 commented Apr 16, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ffrog8

ffrog8 commented Apr 17, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #38. This branch was based on stale history; the changes were rebuilt cleanly on current master and re-submitted there.

@ffrog8 ffrog8 closed this Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant