Skip to content

[codex] Add power snapshot diagnostic topics - #36

Merged
ffrog8 merged 4 commits into
masterfrom
feature/power-snapshot-diag-topics
Apr 16, 2026
Merged

ffrog8 merged 4 commits into
masterfrom
feature/power-snapshot-diag-topics

Conversation

@ffrog8

@ffrog8 ffrog8 commented Apr 15, 2026

Copy link
Copy Markdown
Owner

Summary

Add retained MQTT power snapshot diagnostic topics for event-triggered traces and cumulative counters.

What changed

  • replace the rolling status/power_snapshot_build buckets with retained diagnostic topics:
    • status/power_snapshot_diag_last
    • status/power_snapshot_diag_counts
  • instrument RS485 transactions so power-snapshot subreads capture quantized total, wait, quiet, attempts, retries, and final result
  • record interesting events for slow snapshots, retries, and impossible low synthetic load values
  • publish per-subread cumulative counters to show which path is misbehaving over time
  • update host tests and E2E expectations for the new diagnostics and current boot-memory baseline
  • document the new topics in README.md

Why

The old build-time buckets were enough to show that snapshots sometimes got slow, but not enough to identify which subread or RS485 behavior caused the spike. The new topics expose the last interesting event and cumulative counts so production devices can be diagnosed without flooding MQTT.

Validation

  • host tests: 237/237 passed, 5421/5421 assertions
  • firmware build: passed
    • real RAM 61976 / 80192
    • real IRAM 62131 / 65536
    • stub RAM 63280 / 80192
    • stub IRAM 60579 / 65536
  • full E2E: 37/37 passed in 1042.913s

@ffrog8

ffrog8 commented Apr 15, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 253a5399a3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Alpha2MQTT/src/main.cpp Resolved
@ffrog8

ffrog8 commented Apr 15, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8aa7ef99a6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Alpha2MQTT/src/main.cpp Resolved
@ffrog8

ffrog8 commented Apr 15, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: df85c19b9b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Alpha2MQTT/src/main.cpp Resolved
@ffrog8

ffrog8 commented Apr 15, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ffrog8
ffrog8 merged commit 1bfe6d1 into master Apr 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant