Skip to content

Qol auto detect surface to volume#1122

Open
RemDelaporteMathurin wants to merge 12 commits intomainfrom
qol-auto-detect-subdomaisn
Open

Qol auto detect surface to volume#1122
RemDelaporteMathurin wants to merge 12 commits intomainfrom
qol-auto-detect-subdomaisn

Conversation

@RemDelaporteMathurin
Copy link
Copy Markdown
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin commented Apr 23, 2026

Description

Needs #1118

Summary

This PR removes the need to explicitly define surface_to_volume when initiliasing a HydrogenTransportProblemDiscontinuous class

Related Issues

Fixes #1117

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔨 Code refactoring (no functional changes, no API changes)
  • 📝 Documentation update
  • ✅ Test update (adding missing tests or correcting existing tests)
  • 🔧 Build/CI configuration change

Testing

  • All existing tests pass locally (pytest)
  • I have added new tests that prove my fix is effective or that my feature works

Code Quality Checklist

  • My code follows the code style of this project (Ruff formatted: ruff format .)
  • My code passes linting checks (ruff check .)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Documentation

  • I have updated the documentation accordingly (if applicable)
  • I have added docstrings to new functions/classes following the project conventions

Breaking Changes

Screenshots/Examples

Additional Notes

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

❌ Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.91%. Comparing base (3c3532e) to head (a6306eb).

Files with missing lines Patch % Lines
src/festim/hydrogen_transport_problem.py 80.00% 1 Missing ⚠️
src/festim/subdomain/volume_subdomain.py 96.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1122      +/-   ##
==========================================
- Coverage   94.92%   94.91%   -0.01%     
==========================================
  Files          44       44              
  Lines        3268     3304      +36     
==========================================
+ Hits         3102     3136      +34     
- Misses        166      168       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QoL: remove surface_to_subdomains

1 participant