feat: add france nuage sponsor - #10
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (6)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded France Nuage to the default sponsor list with its website, light logo, dark logo, and partner tier. ChangesSponsor directory
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds France Nuage to the shared sponsor list, so it appears on the website sponsors section, the docs sidebar, and the blog sidebar.
Companion to ferriskey/ferriskey#1219, which adds the same logo to the main README.
Sponsor, not supporter — and why that matters
packages/ui/src/lib/sponsors.tsholds two distinct lists, and the choice is not cosmetic:apps/docs/src/components/toc.tsx:133renders<SponsorCards sponsors={defaultSponsors} />only. An entry added todefaultSupporterswould never appear in the documentation.France Nuage is therefore added to
defaultSponsorswithtier: 'partner'(leadis held by Cloud IAM, and the section renders a single lead).Note that
defaultSponsorsis commented in-code as "Financial partners — fund development directly." — please confirm that framing is accurate for this relationship before merging.Changes
packages/ui/src/lib/sponsors.ts— oneSponsorentry appendedfrance-nuage-light.png/france-nuage-dark.pngadded topublic/sponsors/in all three apps (website,docs,blog), matching how every existing logo is duplicated per appAssets come from the official France Nuage media kit (https://france-nuage.fr/entreprise/mediakit),
logo-with-namelockup at 1024×228 (34 KB / 22 KB).Why PNG rather than SVG
The media kit also ships SVGs, but they render the wordmark as a live
<text>element withfont-family="Inter, …"rather than outlined paths. Logos here are loaded via<img src>, which creates an isolated document that cannot reach the page's webfonts — so the wordmark would fall back to Helvetica/Arial regardless of the site loading Inter. PNG avoids an off-brand render, and is already the precedent here (nudibranches.png,mineral.png,cloudiam.png,polytech-montpellier.png).Verification
sponsors.tstypechecks clean understrict.logoUrlLight/logoUrlDarkin the file resolves to a real file in all three apps — all 9 entries pass, not just the new one.max-h-8 max-w-[120px] object-contain) and the docs sidebaraspect-squarecell. Legible in both themes, optical weight consistent with Anthropic and Gilded Health.Note: in the docs sidebar's square cells, wide lockups render small — France Nuage behaves exactly like Cloud-IAM there. Pre-existing layout constraint, not introduced here, but worth a separate look if it bothers you.
The dev server could not be booted locally to confirm in-app (
@rollup/rollup-darwin-x64missing — the installed native is arm64 while the localnodeis an x64 build). Pre-existing environment mismatch, unrelated to this change.Summary by CodeRabbit