Repository navigation
replace express-hbs with more recent express-handlebars - #209
Merged
Merged
Conversation
Member
Author
|
NOT TO BE MERGED There are significant differences between the two libraries. I currently can't get |
Member
|
I wonder, is there anything we do with Handlebars that can be open coded with ES6 as it exists today. I'm not sure how to search for uses of Handlebars, but if I could find them I'd enjoy rewriting them. |
Member
Author
Resolved in wiki-security-social by using a separate renderer. Will need to apply the same change to other plugins, like wiki-security-passportjs, that make use of |
paul90
added a commit
to fedwiki/wiki-security-social
that referenced
this pull request
Apr 18, 2026
needed to work with express-handlebars migration in fedwiki/wiki-server#209
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.