Fixed logic to check if SP Metadata contains support for SHA-256 signing - #87
Open
bigdavisc wants to merge 1 commit into
Open
Fixed logic to check if SP Metadata contains support for SHA-256 signing#87bigdavisc wants to merge 1 commit into
bigdavisc wants to merge 1 commit into
Conversation
Author
|
I will note that while this PR is likely sufficient to achieve the behavior that I believe the original author was intending to implement, it may be worthwhile to consider additional functionality to also check for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address #86, this change corrects the logic in
Get-ADFSTkSecureHashAlgorithmto correctly look for<alg:SigningMethod Algorithm="http://www.w3.org/2001/04/xmldsig-more#rsa-sha256"/>in the top-level<md:Extensions>section of the<EntityDescriptor>.