Skip to content

[DEV-16797] Handle additional values in deletes - #4859

Merged
sethstoudenmier merged 1 commit into
stagingfrom
fix/dev-16797-handle-fpds-deletes-as-decimal
Nov 10, 2026
Merged

sethstoudenmier merged 1 commit into
stagingfrom
fix/dev-16797-handle-fpds-deletes-as-decimal

Conversation

@sethstoudenmier

@sethstoudenmier sethstoudenmier commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Description:

Fix an issue where procurement transactions weren't correctly removed.

Technical Details:

Records pulled from S3 were found to include decimals that conflicted with previous logic that checked for numeric vs non-numeric. This update adds in extra handling to capture this case and others.

Requirements for PR Merge:

  1. Unit & integration tests updated
  2. API documentation updated (examples listed below)
    1. API Contracts
    2. API UI
    3. Comments
  3. Data validation completed (examples listed below)
    1. Does this work well with the current frontend? Or is the frontend aware of a needed change?
    2. Is performance impacted in the changes (e.g., API, pipeline, downloads, etc.)?
    3. Is the expected data returned with the expected format?
  4. [N/A] Appropriate Operations ticket(s) created
  5. Jira Ticket(s)
    1. DEV-16797

Explain N/A in above checklist:

@sethstoudenmier sethstoudenmier added the hotfix [PR] makes a change in production label Nov 10, 2026
@sethstoudenmier
sethstoudenmier merged commit 5b22bee into staging Nov 10, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotfix [PR] makes a change in production

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants