Conversation
dodok8
force-pushed
the
trailing-dot
branch
from
September 20, 2026 13:40
c34581f to
0082eef
Compare
2chanhaeng
requested changes
Sep 24, 2026
2chanhaeng
left a comment
2chanhaeng
left a comment
Member
There was a problem hiding this comment.
First, tests for #81 are needed.
Also, this PR seems to contain more changes related to reducing multiple origins to a single origin than changes related to #81. Wouldn’t it be better to keep the PR and create a separate issue for this? It would also be helpful to include in the issue the reasons for changing to a single origin.
It also seems that the documentation needs to be updated. Searching the codebase for DRFED_LOGIN_ORIGINS, loginOrigins, and similar terms still turns up a lot of outdated documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #81
Change:
--login-originoptions for running SeverURLof--login-originand its origin..envto set value, like--root-origin.